Skip to content

Xblanchot/ /fix sca cassettes and tests#71

Merged
pierrelalanne merged 2 commits intomasterfrom
xblanchot/-/fix_sca_cassettes_and_tests
Sep 26, 2023
Merged

Xblanchot/ /fix sca cassettes and tests#71
pierrelalanne merged 2 commits intomasterfrom
xblanchot/-/fix_sca_cassettes_and_tests

Conversation

@xblanchot-gg
Copy link
Contributor

Removes deprecated field from client and fixes tests for SCA.

@xblanchot-gg xblanchot-gg self-assigned this Sep 26, 2023
@xblanchot-gg xblanchot-gg added the skip-changelog No changelog check in the CI label Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #71 (487b7aa) into master (875a409) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.02%     
==========================================
  Files           6        6              
  Lines         615      614       -1     
==========================================
- Hits          567      566       -1     
  Misses         48       48              
Flag Coverage Δ
unittests 92.18% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pygitguardian/sca_models.py 100.00% <ø> (ø)
pygitguardian/client.py 79.82% <0.00%> (ø)

@pierrelalanne pierrelalanne merged commit c1c05cd into master Sep 26, 2023
@pierrelalanne pierrelalanne deleted the xblanchot/-/fix_sca_cassettes_and_tests branch September 26, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No changelog check in the CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments