Pin urllib3 to prevent bad dependencies resolving on MacOS with Python3.10 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cOS with Python3.10
agateau-gg
requested changes
Sep 26, 2023
| @@ -15,7 +15,7 @@ isort = "*" | |||
| pre-commit = "*" | |||
| pytest = "*" | |||
| vcrpy = ">=4.3.0,!=4.3.1,<4.4.0" # v4.3.1 broke decode_compressed_response | |||
| urllib3 = "<2" # pin until https://github.com/kevin1024/vcrpy/issues/688 is fixed | |||
| urllib3 = "1.26.16" # pin until https://github.com/kevin1024/vcrpy/issues/688 is fixed | |||
There was a problem hiding this comment.
To pin the dependency you need to change this to:
Suggested change
| urllib3 = "1.26.16" # pin until https://github.com/kevin1024/vcrpy/issues/688 is fixed | |
| urllib3 = "==1.26.16" # pin until https://github.com/kevin1024/vcrpy/issues/688 is fixed |
But I think we can avoid doing so by updating vcrpy instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unknown reason, dependencies installation results in urllib3 not being below version 3 on MacOS with Python3.10.
Actually, worse than that: the install is flaky...