Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sca): scan_diff did not send scan params because of use of post method with data #91

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

xblanchot-gg
Copy link
Contributor

SCA scan_diff did not send scan params because of use of post method with data.
Adds regression tests for this case with both sca scan diff and sca scan all.

@xblanchot-gg xblanchot-gg added the skip-changelog No changelog check in the CI label Jan 17, 2024
@xblanchot-gg xblanchot-gg self-assigned this Jan 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8a3c6b) 92.42% compared to head (f7b80be) 92.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files           6        6           
  Lines         647      647           
=======================================
  Hits          598      598           
  Misses         49       49           
Flag Coverage Δ
unittests 92.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gg-mmill gg-mmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks !

@xblanchot-gg xblanchot-gg merged commit ce70ae4 into master Jan 18, 2024
20 checks passed
@xblanchot-gg xblanchot-gg deleted the xblanchot/-/fix_sca_scan_diff_params branch January 18, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog check in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants