Skip to content

Tweak select project ux #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

divine-comedian
Copy link
Contributor

@divine-comedian divine-comedian commented Aug 1, 2025

in select project view on create cause:

  • remove learn more button on project card
  • stop height change of card on hover
  • add link open in new tab when hovering title or description
  • on right hand select project list: show author name instead of 1st main category

Summary by CodeRabbit

  • New Features

    • Project titles and descriptions are now directly clickable, opening the project page in a new tab.
  • Improvements

    • The hover overlay with "Learn More" has been removed for a simpler, more direct interaction.
    • Selected projects now display the admin user's name instead of the project category.

Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2025 5:14pm

Copy link
Contributor

coderabbitai bot commented Aug 1, 2025

Walkthrough

The updates remove hover state logic and the hover overlay UI from the CauseCreateProjectCard component, making the project title and description directly clickable links. In CauseSelectedProjects, the displayed category is replaced with the project's admin user name. No exported function or component signatures were changed.

Changes

Cohort / File(s) Change Summary
Hover State & UI Removal
src/components/views/causes/create/CauseCreateProjectCard.tsx
Eliminated hover state logic, removed hover overlay, made title and description clickable links, updated styles, and deleted unused imports and styled components.
Project Info Display Update
src/components/views/causes/create/CauseSelectedProjects.tsx
Changed displayed text from project category to admin user name for each selected project.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • ae2079

Poem

A card once hovered, now stands still,
Its links are bright and clickable at will.
No overlays dance, no icons in sight,
Just titles and text, clear and light.
The admin’s name now takes the stage—
Simpler code upon the page!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2419574 and a0d58b5.

📒 Files selected for processing (2)
  • src/components/views/causes/create/CauseCreateProjectCard.tsx (6 hunks)
  • src/components/views/causes/create/CauseSelectedProjects.tsx (1 hunks)
🔇 Additional comments (8)
src/components/views/causes/create/CauseCreateProjectCard.tsx (7)

1-1: LGTM: Clean import removal

The removal of the unused IconExternalLink16 import is correct since the hover overlay UI has been removed.


94-94: LGTM: Simplified wrapper implementation

Removing the hover event handlers aligns with the PR objective to prevent card height changes on hover while maintaining the hover transform effects in CSS.


98-106: LGTM: Proper implementation of clickable title

The title is now wrapped in a Link component with appropriate security attributes (target='_blank' and rel='noopener noreferrer'). This successfully replaces the hover overlay approach with direct clickability.


124-132: LGTM: Consistent implementation for description

The description follows the same pattern as the title with proper Link wrapping and security attributes. This maintains consistency across the clickable elements.


241-247: LGTM: Well-structured CSS for interaction states

The CSS correctly enables pointer events for the container while initially disabling them for anchor tags, then re-enabling them specifically for the clickable links. This prevents unintended interactions while allowing the intended clickable behavior.


273-276: LGTM: Proper CSS override for title links

The CSS correctly overrides the pointer events for anchor tags within the Title component, making them clickable as intended.


326-329: LGTM: Consistent CSS for description links

The Description component follows the same CSS pattern as the Title, ensuring consistent clickable behavior across both elements.

src/components/views/causes/create/CauseSelectedProjects.tsx (1)

118-118: LGTM: Clear improvement in displayed information

Changing from category display to admin user name provides more relevant and actionable information to users when reviewing selected projects. The optional chaining properly handles cases where adminUser might be undefined.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tweak-select-project-UX

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant