Add ATmega8 and fix some minor bugs with program-avr-spi applet #736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes here:
erase_time
was chosen to match the other entry with anerase_time
, since not having one seemed to lead to issues with verifying what had been written, and this one seems to work fineprogram-avr-spi
applet so it doesn't give a traceback whenever you're doing something with an unidentified deviceFor an explanation of the second one, see the following output I got before adding the ATmega8:
This is actually the result of two different things that needed to be fixed:
device
object before it checked to see if the device existed (so this change brings that further up)I don't know if a simple
return
is what's wanted here, but I assume the point of the check was to not error out on an unidentified device because it's already done everything that's needed for theidentify
command