software: add toolchain integration for Emscripten #960
Conversation
whitequark
changed the title
whitequark
force-pushed
the
pyodide
branch
7 times, most recently
from
0423618 to
44a0245
Compare
|
I reviewed all the changes. Everything looks good to me except for two small issues (see diff), and two questions I have (see questions). In |
whitequark
force-pushed
the
pyodide
branch
2 times, most recently
from
986d4f4 to
e0324cc
Compare
|
Thanks, all good calls.
This is a remnant from an earlier implementation.
This is a remnant from an earlier bug. The version functions actually all return strings (they aren't compared, but they are hashed). It's kind of an odd API. It should be |
whitequark
force-pushed
the
pyodide
branch
2 times, most recently
from
76e34f1 to
c3fcc3a
Compare
Primarily useful for the Emscripten port, but can also be used to amortize startup latency in other cases.
Primarily useful for Emscripten port.
Required for WebUSB backend.
This integration expects a global object like this:
globalThis.glasgowToolchain = {
packages: {
'yosys': '0.55',
'nextpnr-ice40': '0.8'
},
available(packageName) {
return packageName in this.packages;
},
version(packageName) {
return this.packages[packageName];
},
async build(files, scriptName, writeLine) {
writeLine("starting build...\n")
// ... do the build...
return {code: 0, files: ...};
}
}
Disconnecting the device seems to produce a `NotFoundError` with "The device was disconnected." in the message. This isn't a great solution but I don't have anything better.
|
OK, I think this is more or less complete. There are still things that don't work on Emscripten but I think we're better off merging this and fixing the rest incrementally. You can get pretty far with the code in this PR. (The main thing that's still broken is Windows support, and I haven't got a faintest clue why.) |
No problem, happy to contribute!
Nice! I also just took a look at the most recent commit (c2be584) and it LTGM. |
To do:
get_bitstreamwasn't async but is async now, something downstream probably brokeasyncio.create_subprocess_execinstead ofPopento avoid blocking when running *nix/Windows too