software/deploy-firmware: skip group addition if group already exists #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the script on a distribution where the current user is using gid 100 fails, as that group already exists inside the image: ``` Setting up libgssapi-krb5-2:arm64 (1.20.1-2+deb12u3) ... Setting up libgdbm-compat4:arm64 (1.23-3) ... Setting up libperl5.36:arm64 (5.36.0-7+deb12u2) ... Setting up libcurl3-gnutls:arm64 (7.88.1-10+deb12u12) ... Setting up perl (5.36.0-7+deb12u2) ... Setting up liberror-perl (0.17029-2) ... Setting up git (1:2.39.5-0+deb12u2) ... Processing triggers for libc-bin (2.36-9+deb12u10) ... + groupadd --gid 100 caller groupadd: GID '100' already exists ``` (nonzero exit code, aborted build) It's fine to skip group creation in this case, we care about the group to exist, not how it's called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the script on a distribution where the current user is using gid 100 fails, as that group already exists inside the image:
(nonzero exit code, aborted build)
It's fine to skip group creation in this case, we care about the group to exist, not how it's called.