Firmware pagesize fix #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Right, firmware updates have to be landed in two PRs |
|
Oh my bad, sorry about that. So for my understanding I should have made one pull request with the code changes + another with the new firmware image? I'll fix this up properly tomorrow. |
|
Yeah! No worries, we don't document this anywhere I think |
Sazzach
force-pushed
the
firmware_pagesize_fix
branch
2 times, most recently
from
7e0ef79 to
4e14e0a
Compare
|
Okay I think this is failing now due to something related to the pending lock file update. I think I may have chosen a bad time to retry this, sorry 😅. My plan is to: Wait for the lock file update to be merged, rebase this PR, wait for this PR to be merged, make a second PR for just the firmware. Let me know if I'm misunderstanding the process. |
whitequark
force-pushed
the
firmware_pagesize_fix
branch
from
4e14e0a to
99a3c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #987.