Changing handling on all-modules.go and the 'go generate' feature

[MorquinDevlar]

Description

When forking the repository, and running "go generate" modules/all-modules.go is created or updated, but since it was previously tracking in the repository it's then added to unstaged files for commit. This is not optimal, as it could potentially mean someone would push their custom all-modules.go file to the main repository.

It's already in .gitignore, but since it was already tracked this is not enough to have ti not appear as a changed file when running "go generate".

Changes

• Added a default modules/all-modules.go to the repo
• Removed all-modules.go from .gitignore
• Removed references to 'go generate' in the Makefile
• Removed cmd/generate/_all-modules.go
• Added proper sorting of modules in modules-import.go

[Volte6]

Dunno whyni thought this was a good idea. Why don't we just commit the generated file with the current set of modules? Thst makes it simple. Make targets that copy over it need to be updated though

[MorquinDevlar]

Would it not invariably change when someone runs "go generate" and then get added to their unstaged files?

[MorquinDevlar]

I've had to "re-fork" so many times because I messed up something in my own repository trying to keep it up to date with the upstream one.

Anything we can do to make it simple would be much appreciated :-)

[Volte6]

I think this PR is a good idea overall. We need to go back to how it was, more or less. I think we should include the following:

• Instead of deleting it, run go generate and commit the results
• Remove modules/all-modules.go from .gitignore
• Remove all references to make ungenerate from Makefile
• Delete cmd/generate/_all-modules.go
• Add sort.Strings(pkgs) to line 47 in module-imports.go, so that we always get a predictable order of modules (and prevent unnecessary file changes).

This makes go generate an optional "helper" step that can be run only when adding or removing modules.

[MorquinDevlar]

Changes are all done now.

[Volte6]

Looks good, we still need the initial all-modules.go to be present (run go generate and commit results). The CI build fails as will anyone trying to run the project without it.

[MorquinDevlar]

Looks good, we still need the initial all-modules.go to be present (run go generate and commit results). The CI build fails as will anyone trying to run the project without it.

I actually thought I did. Did I not add it correctly? It was supposed to be this commit: 27c6854

[Volte6]

Looks good, we still need the initial all-modules.go to be present (run go generate and commit results). The CI build fails as will anyone trying to run the project without it.

I actually thought I did. Did I not add it correctly? It was supposed to be this commit: 27c6854

My bad, I misinterpreted what I was seeing.

[Volte6]

Looks good, thanks!

[MorquinDevlar]

I am very happy to help :)

[MorquinDevlar]

I forgot to add the sorting - that is now added in the last commit.