Create password encrypted wallet.json instead of privileged private.key #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other commands would need to be updated as a result of this since they use the private.key file still. Let me know if I'm barking up the wrong tree, just trying to make sure the format is consistent between |
draganm
requested changes
Aug 13, 2025
| }, nil | ||
|
|
||
| } | ||
|
|
||
| // readPassword reads a password from stdin if piped, or interactively if in a terminal | ||
| func readPassword() (string, error) { |
There was a problem hiding this comment.
aren't CreatePassword and this the same thing?
There was a problem hiding this comment.
CreatePassword confirms the password and checks that they match when you are creating a new account, readPassword does not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the geth account keystore module to generate a new key and store it in a wallet.json file, encrypting it with a passphrase, instead of storing a private key in a privileged key file.