Merge with yagna sdk #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieznanysprawiciel
force-pushed
the
merge-yagna-functionalities
branch
2 times, most recently
from
8bb8e5a to
ffad437
Compare
nieznanysprawiciel
force-pushed
the
merge-yagna-functionalities
branch
from
ffad437 to
997ac0e
Compare
yvan-sraka
approved these changes
May 14, 2025
There was a problem hiding this comment.
There's quite a bit of refactoring noise (renaming and moving things around) in this PR, which makes it pretty large and harder to review. I would have really preferred it split into several smaller, semantically-focused PRs, as there’s a lot going on here.
That said, I think these are great additions overall and should definitely be merged. I’m not sure if you prefer to squash the commits or keep the commit history (feel free to clean it up if needed)? Then we can check if the CI passes, iterate if necessary, and go ahead with a release :)
Thanks for the great work!
nieznanysprawiciel
force-pushed
the
merge-yagna-functionalities
branch
2 times, most recently
from
a33b949 to
7f28740
Compare
nieznanysprawiciel
force-pushed
the
merge-yagna-functionalities
branch
from
7f28740 to
3f809ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.