fix(usage): add chrome namespace to Window and add usage directions, fixes #17#34
fix(usage): add chrome namespace to Window and add usage directions, fixes #17#34MichaelSolati wants to merge 1 commit intoGoogleChrome:mainfrom
chrome namespace to Window and add usage directions, fixes #17#34Conversation
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 35.47% 35.47%
=======================================
Files 21 21
Lines 3986 3986
Branches 183 183
=======================================
Hits 1414 1414
Misses 2572 2572 Continue to review full report at Codecov.
|
|
@devnook ptal |
|
this will not force it to be a primary resolution in case some third party package installed |
|
@olso-nordsec without being in the |
|
For now, I'm using diff --git a/node_modules/chrome-types/index.d.ts b/node_modules/chrome-types/index.d.ts
index 4438d02..41e7899 100644
--- a/node_modules/chrome-types/index.d.ts
+++ b/node_modules/chrome-types/index.d.ts
@@ -1,3 +1,4 @@
+declare module 'chrome-types' {
/**
* Copyright 2022 Google LLC
*
@@ -28738,3 +28739,4 @@ declare namespace chrome {
): void;
}
}
+}and then using it as import type { chrome } from 'chrome-types'; |
dist/global.d.tswhich takes the build output and adds it to the Window interface.dist/README.mdto document how to include this lib into a projects global typings..gitignoreto includedist/global.d.ts.dist/package.template.jsonwith some keywords for search on npm.See this video for a little better explenation. I also didn't want to modify any of the existing files so that we don't break the chrome types being used for dcc.