Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: allow placeholder anchor elements #16287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hiroya-uga
Copy link

Summary

Acknowledgements: This is a continuation of Mr. @romainmenke 's great pull request. [#15894]

Anchor elements without an href or specific attributes are considered placeholder elements and should not produce audit failures.

See : #15820 (comment)

Since #15894 says there are many issues to be resolved, I would like to allow at least the a element that clearly indicates that it is a placeholder.

Related Issues/PRs

Base : #15894
Fixes : #15820

@adamraine
Copy link
Member

Thanks for the contribution! This is a pretty specific exception IMO even if the use case is well defined.

I looked into creating a general-case solution in #16292. I can't gurantee the solution will land given some of its complexity, so if we can't justify that solution then we can circle back to creating exception cases like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse warns when an anchor tag is just a placeholder
2 participants