New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enums to sort by browser feature support #1073

Open

jcscottiii wants to merge 1 commit into main from jcscottiii/expand-sorting-enum

Collaborator

jcscottiii commented Jan 17, 2025

No description provided.


          Add enums to sort by browser feature support

9c92d0f

Collaborator Author

jcscottiii commented Jan 17, 2025

@jrobbins I currently use desktop_availability_{browser}_{direction} to match the column keys in the frontend:

webstatus.dev/frontend/src/static/js/components/webstatus-overview-cells.ts

Lines 61 to 64 in b9e031f

    
           DesktopAvailabilityChrome = 'desktop_availability_chrome', 
        
           DesktopAvailabilityEdge = 'desktop_availability_edge', 
        
           DesktopAvailabilityFirefox = 'desktop_availability_firefox', 
        
           DesktopAvailabilitySafari = 'desktop_availability_safari',

But when we bring on mobile support (#996), we will use the keys from web features: https://github.com/web-platform-dx/web-features/blob/580ce2ca36a2a603efa15df46592569a08f802d0/packages/compute-baseline/src/baseline/core-browser-set.ts#L3-L12

export const identifiers = [
  "chrome",
  "chrome_android",
  "edge",
  "firefox",
  "firefox_android",
  "safari",
  "safari_ios",
];

Thoughts on removing the desktop_ prefix so that enum will be availability_{browser}_{direction}?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet