Refactor: Use httptest for HTTP layer testing #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the reliability and maintainability of our HTTP tests by transitioning from direct calls to the generated OpenAPI server methods to using the
httptest
package for true HTTP-level testing.Motivation:
Currently, our tests bypass the HTTP layer, which limits their ability to identify issues with request handling, middleware, and serialization. This refactor provides a more accurate representation of real-world scenarios and enables better testing of components like the upcoming auth middleware.
Changes:
httptest
Integration: All HTTP handler tests now utilizehttptest
to simulate actual HTTP requests and responses. This involves updating test inputs to*http.Request
and expected outputs to*http.Response
.assertTestServerRequest
andassertMockCallCount
to reduce code duplication and improve consistency across tests.Benefits:
Future Work: