Add --diff argument to benchmark-web-vitals and benchmark-server-timing
#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into add/benchmark-diff * 'main' of https://github.com/GoogleChromeLabs/wpp-research: Throw error instead of logging Remove needless variable defined outside try/catch Catch puppeteer errors to count toward non-success rate
… into add/benchmark-diff * 'main' of https://github.com/GoogleChromeLabs/wpp-research: Fix lint errors Allow passing multiple URLs by repeating the --url arg when benchmarking Update commander to v14 Show error when all benchmark requests for a URL failed Ensure browser is closed when network priming request fails Prevent terminal from linkifying ... as part of the logged URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #186.
The most common use case for benchmarking two URLs is to see the performance impact before/after. To do this, I would often copy the CSV output into a Google Sheet and then add columns to compute the difference in terms of milliseconds and percentage. Since this is such a common scenario (at least for me), this PR adds support for passing
--diffwhen callingbenchmark-web-vitalsorbenchmark-server-timing, if the--filearg is referring to a file that contains two URLs.Example output: