Allows non ancestor queries inside a transaction

[step76]

Hello,

As stated here, the new Firestore in Datastore mode allows executing non-ancestor queries inside a transaction. The library enforces the previous behaviour, so these changes allow leveraging the new feature using the legacy bundle.

This could be useful for many people still using the legacy bundle.

[ludoch]

Anyway we can add a test via the local appengine datastore dev emulator?
Is it only a client library change or do we need to change the dev emulation as well?

[step76]

Anyway we can add a test via the local appengine datastore dev emulator? Is it only a client library change or do we need to change the dev emulation as well?

I also changed the emulator. The change was pretty trivial. There was a point where the code assumed there was an ancestor in a transaction context, trusting the checks done in the library, so I changed that check to separate the transaction logic and the ancestor logic. The emulator implementation remained the same.

[maigovannon]

Maybe I am way off here...but doesn't this change enforce the firestore in datastore mode for all callers? What about the clients who are using in just plain datastore calls? Shouldn't they still mandate enforcing Ancestor queries? @ludoch

[step76]

Maybe I am way off here...but doesn't this change enforce the firestore in datastore mode for all callers? What about the clients who are using in just plain datastore calls? @ludoch

As far as I know all the datastore instsances were automatically migrated to the new Firestore in Datastore mode.

[ludoch]

Thanks, just so that I have all the context, where "I also changed the emulator...." did you do the change?
Google3? CL?

[step76]

Thanks, just so that I have all the context, where "I also changed the emulator...." did you do the change? Google3? CL?

I'm talking about the local dev server contained in this project. One of the three files I've changed in this PR i about the local dev server.

[ludoch]

Approval, but still need to wait for extra internal tests done inside Google code base.

[ludoch]

We have more internal tests still using TRANSACTION_REQUIRES_ANCESTOR that are now failing, so we also need to propagate this change internally,
Sorry about that, it will take a few cycles on our side, and we might have to clone this internally before doing the gh change.
Thanks for you contribution!