Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds new ipynb for combining/using multiple analyses #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthiasak
Copy link
Member

Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthiasak a few things:

  • Clean up the exposed project_id, agent_id, gcs_path throughout the notebook
  • Use placeholder values for them where applicable:
    • i.e. projects/{project_id}/locations/{location}/agents/{agent_id}
  • Clean up cell outputs that expose project_id, agent_id data or any unnecessary data that you don't want exposed (i.e. training phrases or intents that might contain PII)
  • If keeping some cell outputs, use df.head() when inspecting results to trim the length of the file for brevity

Overall, looks great! Quite an in depth analysis notebook! 👏

@kmaphoenix
Copy link
Member

@matthiasak ping!

@matthiasak
Copy link
Member Author

matthiasak commented Oct 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants