Skip to content

[Random Reader Refactoring] Enable new reader implementation by default #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Jun 11, 2025

Description

  • Enable new reader implementation by default

Link to the issue in case of a bug fix.

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Automated
  4. Composite tests - Automated
  5. Perf tests
    i. Flat bucket
    kEj8pqvF9DhwUhq
    ii. Zonal bucket
    BptACiobcerrY7k

Any backward incompatible change? If so, please explain.

@Tulsishah Tulsishah added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (a95f8a8) to head (b14bfd7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3402      +/-   ##
==========================================
+ Coverage   78.84%   78.87%   +0.02%     
==========================================
  Files         140      140              
  Lines       18470    18470              
==========================================
+ Hits        14563    14568       +5     
+ Misses       3423     3420       -3     
+ Partials      484      482       -2     
Flag Coverage Δ
unittests 78.87% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tulsishah Tulsishah added execute-integration-tests Run only integration tests random-reader-refactoring and removed execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR labels Jun 11, 2025
@Tulsishah Tulsishah force-pushed the enable_read_manager_flag branch 2 times, most recently from bc9e487 to e3942c9 Compare June 19, 2025 16:27
@Tulsishah Tulsishah added the execute-perf-test Execute performance test in PR label Jun 19, 2025
@Tulsishah Tulsishah force-pushed the enable_read_manager_flag branch from 068284e to 1a274c1 Compare June 23, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR random-reader-refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant