-
Notifications
You must be signed in to change notification settings - Fork 460
Update benchmark results for version v3.0.0 #3408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update benchmark results for version v3.0.0 #3408
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3408 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 137 138 +1
Lines 18313 18324 +11
=======================================
+ Hits 14440 14450 +10
- Misses 3389 3390 +1
Partials 484 484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3de5e00
to
8998e26
Compare
8998e26
to
d7938ed
Compare
| 50M | 1M | 20 | 3166.878 | 3.02K | 15.49ms | | ||
| 100M | 1M | 10 | 2835.631 | 2.70K | 21.63ms | | ||
| 1G | 1M | 2 | 2502.955 | 2.39K | 14.02ms | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add if any new steps are added below in steps to benchmark. I see its mentioned you had prefetch etc. good to mention in the steps so customers can redo it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These benchmarks are not reproducible at a single row level so even if mention it there may be variations, We have logged a bug (b/423764522) to fix this in future. Let me know if we need to do for V3.0.0 benchmark update as it was decided in a thread to not do for V3.0.0
CC(folks who are involved in the discussion): @mustvicky @anushka567 @ashmeenkaur
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we can add the conditions for the benchmarks though. wdyt? @anushka567
docs/benchmarks.md
Outdated
| 50M | 1M | 20 | 3592 | 3592 | 2.35 | | ||
| 100M |1M | 10 | 4549 | 4549 | 7.04 | | ||
| 1G | 1M | 2 | 2398 | 2398 | 37.07 | | ||
| 256K | 16K | 30 | 257.922 | 15.74K | 2.67ms | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also assuming this bump up is due to GiB to GB conversion for other ones. Here it is due to streaming writes.
Hoping the numbers are validated by @ashmeenkaur or @vadlakondaswetha
Description
Update benchmarking numbers for GCSFuse Version v3.0.0 at tag
v3.0.0
ls -R "$MOUNT_POINT"
Link to the issue in case of a bug fix.
b/415727864
Testing details
Any backward incompatible change? If so, please explain.