Skip to content

Update benchmark results for version v3.0.0 #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

meet2mky
Copy link
Collaborator

@meet2mky meet2mky commented Jun 12, 2025

Description

Update benchmarking numbers for GCSFuse Version v3.0.0 at tag v3.0.0

  • For each read benchmark metadata cache was prefetched using ls -R "$MOUNT_POINT"
  • For each write benchmark we ran it twice to ensure first benchmark creates files and then we delete files to ensure negative stat cache and then results of second write benchmarks were taken.
  • Converted GiB and MiB to GB and MB for bandwidth calculation.
  • Used numjob=48 for 1G write benchmarks instead of numjob=112 (Ref: Update public benchmarks for gcsfuse version v3.0.0 #3399)

Link to the issue in case of a bug fix.

b/415727864

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (9a7bdf7) to head (a2651f7).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3408   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files         137      138    +1     
  Lines       18313    18324   +11     
=======================================
+ Hits        14440    14450   +10     
- Misses       3389     3390    +1     
  Partials      484      484           
Flag Coverage Δ
unittests 78.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meet2mky meet2mky force-pushed the update-benchmarks-for-gcs-fuse-version-v3.0.0-timestamp-1749714037328193284 branch from 3de5e00 to 8998e26 Compare June 13, 2025 07:12
@meet2mky meet2mky force-pushed the update-benchmarks-for-gcs-fuse-version-v3.0.0-timestamp-1749714037328193284 branch from 8998e26 to d7938ed Compare June 16, 2025 06:48
@meet2mky meet2mky requested a review from charith87 June 20, 2025 06:40
@meet2mky meet2mky self-assigned this Jun 20, 2025
| 50M | 1M | 20 | 3166.878 | 3.02K | 15.49ms |
| 100M | 1M | 10 | 2835.631 | 2.70K | 21.63ms |
| 1G | 1M | 2 | 2502.955 | 2.39K | 14.02ms |

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add if any new steps are added below in steps to benchmark. I see its mentioned you had prefetch etc. good to mention in the steps so customers can redo it as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These benchmarks are not reproducible at a single row level so even if mention it there may be variations, We have logged a bug (b/423764522) to fix this in future. Let me know if we need to do for V3.0.0 benchmark update as it was decided in a thread to not do for V3.0.0
CC(folks who are involved in the discussion): @mustvicky @anushka567 @ashmeenkaur

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we can add the conditions for the benchmarks though. wdyt? @anushka567

| 50M | 1M | 20 | 3592 | 3592 | 2.35 |
| 100M |1M | 10 | 4549 | 4549 | 7.04 |
| 1G | 1M | 2 | 2398 | 2398 | 37.07 |
| 256K | 16K | 30 | 257.922 | 15.74K | 2.67ms |
Copy link
Collaborator

@charith87 charith87 Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also assuming this bump up is due to GiB to GB conversion for other ones. Here it is due to streaming writes.
Hoping the numbers are validated by @ashmeenkaur or @vadlakondaswetha

@meet2mky meet2mky requested a review from charith87 June 20, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants