remove extra go routine in read flow #3448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the read flow when we read data from range reader into the buffer, GCSFuse creates a goroutine which takes care of checking for context cancelled while waiting for data from network. Since interrupts are disabled by default, there is no need of creating this goroutine always for every read request. Create this go routine only if user wants interrupts to be handled.
Link to the issue in case of a bug fix.
b/425859120
Testing details
Manual profiline results:
Before optimization:
After optimization:
Any backward incompatible change? If so, please explain.
NA