Skip to content

Fix typo in e2e test script and a condition check. #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

meet2mky
Copy link
Collaborator

@meet2mky meet2mky commented Jun 30, 2025

Description

Typo fixes for e2e script and an if condition which was not evaluating as intended after this PR: #3433
Now it's working as intended:
image

Link to the issue in case of a bug fix.

b/426462003

Testing details

  1. Manual - Yes
  2. Unit tests - NA
  3. Integration tests - Run as part of presubmit.

Any backward incompatible change? If so, please explain.

@meet2mky meet2mky requested a review from gargnitingoogle June 30, 2025 05:43
@meet2mky meet2mky self-assigned this Jun 30, 2025
@meet2mky meet2mky requested review from Tulsishah and a team as code owners June 30, 2025 05:44
@meet2mky meet2mky added the execute-integration-tests Run only integration tests label Jun 30, 2025
@meet2mky meet2mky requested a review from kislaykishore June 30, 2025 05:44
@kislaykishore kislaykishore requested a review from a team June 30, 2025 05:44
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (95ef056) to head (a000413).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3459      +/-   ##
==========================================
+ Coverage   78.98%   78.99%   +0.01%     
==========================================
  Files         140      140              
  Lines       18520    18520              
==========================================
+ Hits        14628    14630       +2     
+ Misses       3405     3403       -2     
  Partials      487      487              
Flag Coverage Δ
unittests 78.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gargnitingoogle gargnitingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meet2mky meet2mky merged commit 58c116e into master Jun 30, 2025
14 checks passed
@meet2mky meet2mky deleted the meet2mky/typo-fixes-e2e branch June 30, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants