Skip to content

chore(secretmanager): Added samples for delayed destroy #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

durgesh-ninave-crest
Copy link
Contributor

Description

Created samples for Global and Regional Secret Manager API

Samples (Global, Regional)

  1. Create Secret With Delayed Destroy
  2. Disable Secret Delayed Destroy
  3. Update Secret With Delayed Destroy

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jul 22, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @durgesh-ninave-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Google Cloud Secret Manager Go samples by introducing examples for the 'delayed destroy' functionality. These new samples provide clear guidance on how to configure and manage the lifecycle of secret versions, ensuring that secrets are not immediately destroyed upon deletion but rather after a specified retention period. The additions cover both global and regional API interactions, making the sample set more robust and useful for a wider range of use cases.

Highlights

  • New Samples for Delayed Secret Destroy: I've added new Go samples demonstrating how to manage secrets with a 'delayed destroy' feature. This includes creating a secret with a specified version destroy TTL, updating an existing secret's destroy TTL, and disabling the delayed destroy feature.
  • Global and Regional API Coverage: The new samples cover both the global and regional Google Cloud Secret Manager APIs, providing comprehensive examples for users operating in different deployment models.
  • Comprehensive Test Coverage: Corresponding system tests have been added for all new samples to ensure their correctness and prevent regressions, covering creation, update, and disable operations for both global and regional secrets.
  • Test File Refactoring: Minor refactoring was performed in the existing test files (secretmanager_test.go and regional_secretmanager_test.go) to remove redundant gRPC import aliases and standardize error handling for NotFound status codes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new samples for creating, updating, and disabling delayed destruction of secrets in Google Cloud Secret Manager, for both global and regional secrets. The changes are well-structured and include corresponding tests. My review focuses on improving code clarity and correctness by fixing inaccurate comments, adhering to Go's naming conventions for initialisms (e.g., secretID instead of secretId), and correcting copy-paste errors in test-failure messages.

@YashSaraf11
Copy link

Please assert in the test scenarios that the delayed destory was disabled or updated. I do not see any assert statements on those tests for the operation verification.

@durgesh-ninave-crest
Copy link
Contributor Author

Please assert in the test scenarios that the delayed destory was disabled or updated. I do not see any assert statements on those tests for the operation verification.

I've updated the assertion to reflect the intended functionality of the sample.

@durgesh-ninave-crest durgesh-ninave-crest marked this pull request as ready for review August 5, 2025 05:20
@durgesh-ninave-crest durgesh-ninave-crest requested review from a team as code owners August 5, 2025 05:20
Copy link

snippet-bot bot commented Aug 5, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants