-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: move blunderbuss team mappings to CODEOWNERS #5361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @briandorsey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made changes to deprecate the Blunderbuss bot's functionality by removing its configuration file and migrating its team assignment logic directly into the CODEOWNERS file. This streamlines the process of assigning reviewers by leveraging path-based assignments instead of label-based ones, ensuring that the correct teams are automatically assigned for code reviews based on the affected files.
Highlights
- Deprecation of Blunderbuss Bot: The Blunderbuss bot, which handled team assignments based on labels, has been deprecated. This change removes its configuration file.
- Migration of Team Mappings to CODEOWNERS: Team assignments previously managed by Blunderbuss are now handled directly within the CODEOWNERS file, mapping teams to specific file paths.
- Cleanup of Test Configuration: The
badfiles_test.go
file was updated to remove the reference to the now-deleted.github/blunderbuss.yml
from its allowList.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates team assignments from the deprecated blunderbuss.yml
to the .github/CODEOWNERS
file. The changes correctly remove the blunderbuss.yml
file and its reference in a test file. However, there are a few issues in the updated CODEOWNERS
file. Some new team entries are missing the required @
prefix, which is a syntax error. There are also a couple of cases where teams seem to be assigned to incorrect paths based on the logic from the old blunderbuss.yml
configuration. I've left specific comments with suggestions to fix these issues.
The [Blunderbuss bot](https://github.com/googleapis/repo-automation-bots/tree/main/packages/blunderbuss) has been deprecated. This change handles team level Blunderbuss assignments by mapping them via paths instead of labels via CODEOWNERS. Nearly all of these cases were already in CODEOWNERS. We will contact individuals referenced in the Blunderbuss config with info on how to create a team and map that team in CODEOWNERS.
5aad05d
to
88e70fa
Compare
The Blunderbuss bot has been deprecated. This change handles team level Blunderbuss assignments by mapping them via paths instead of labels via CODEOWNERS. Nearly all of these cases were already in CODEOWNERS. We will contact individuals referenced in the Blunderbuss config with info on how to create a team and map that team in CODEOWNERS.
Description
Addresses b/434771456 for this repo.