Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) User "system:serviceaccount:istio-system:kf-admin" cannot list resource "pods" in API group "" in the namespace "istio-system #381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabito
Copy link
Contributor

@fabito fabito commented Aug 17, 2022

After this commit: dcc4051
backend_updater started using the pod resource (as opposed to deployment) to fetch the healthcheck ingress path and the following error started:

Error from server (Forbidden): pods is forbidden: User "system:serviceaccount:istio-system:kf-admin" cannot list resource "pods" in API group "" in the namespace "istio-system

This PR grants pods listing permissions to kf-admin KSA to fix backend-updater errors.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabito
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval by writing /assign @zijianjoy in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @fabito. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -9,6 +9,7 @@ rules:
- services
- configmaps
- secrets
- pods
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a separate permission which allows only get and list?


- apiGroups:
  - ""
  resources:
  - pods
  verbs:
  - get
  - list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants