Added support for application awareness on interconnect

[abhijeetkjha-google]

compute: added `applicationAwareInterconnect` and `aaiEnabled` field in `google_compute_interconnect` resource

This feature allows customers to explicitly control how the bandwidth at the Cloud Interconnect -> Customer on-prem router is managed for the traffic egressing Google Cloud on their Dedicated Interconnect or Cross-Cloud Interconnect deployments.

With application awareness on Interconnect, customers have the ability to define how their Interconnect capacity is shared across their different workloads and ensure higher reliability for their mission-critical traffic.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 616 insertions(+))
google-beta provider: Diff ( 4 files changed, 616 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 615 insertions(+))
google-beta provider: Diff ( 4 files changed, 615 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update
• TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update
• TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 211 insertions(+))
google-beta provider: Diff ( 4 files changed, 617 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update
• TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 211 insertions(+))
google-beta provider: Diff ( 4 files changed, 617 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update
• TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update
• TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

• compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update
• TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test