Added support for application awareness on interconnect #14267

abhijeetkjha-google · 2025-06-13T08:10:23Z

compute: added `applicationAwareInterconnect` and `aaiEnabled` field in `google_compute_interconnect` resource

This feature allows customers to explicitly control how the bandwidth at the Cloud Interconnect -> Customer on-prem router is managed for the traffic egressing Google Cloud on their Dedicated Interconnect or Cross-Cloud Interconnect deployments.

With application awareness on Interconnect, customers have the ability to define how their Interconnect capacity is shared across their different workloads and ensure higher reliability for their mission-critical traffic.

…update test.

github-actions · 2025-06-13T08:11:16Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-06-13T08:23:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 616 insertions(+))
google-beta provider: Diff ( 4 files changed, 616 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-13T08:29:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 615 insertions(+))
google-beta provider: Diff ( 4 files changed, 615 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-13T08:50:27Z

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-13T08:51:15Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-13T08:56:18Z

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-13T08:57:04Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-13T09:09:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 211 insertions(+))
google-beta provider: Diff ( 4 files changed, 617 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-13T09:36:34Z

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-13T09:37:22Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-06-18T09:43:45Z

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2025-06-18T10:29:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 211 insertions(+))
google-beta provider: Diff ( 4 files changed, 617 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-18T10:57:33Z

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-18T10:58:20Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-18T10:59:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 215 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-18T11:25:04Z

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-18T11:25:51Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-18T12:20:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-18T12:34:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-18T12:48:46Z

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-18T12:49:35Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-18T13:03:17Z

Tests analytics

Total tests: 1225
Passed tests: 1140
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-18T13:04:07Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-18T19:48:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-18T19:54:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  aai_enabled = # value needed
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-18T20:14:06Z

Tests analytics

Total tests: 1226
Passed tests: 1141
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-18T20:14:54Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-18T20:20:59Z

Tests analytics

Total tests: 1226
Passed tests: 1141
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-18T20:21:47Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-06-18T20:26:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+))
google-beta provider: Diff ( 4 files changed, 621 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  application_aware_interconnect {
    bandwidth_percentage_policy {
      bandwidth_percentage {
        percentage    = # value needed
        traffic_class = # value needed
      }
    }
    profile_description = # value needed
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

modular-magician · 2025-06-18T20:52:38Z

Tests analytics

Total tests: 1226
Passed tests: 1141
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages

compute

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

modular-magician · 2025-06-18T20:53:27Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]
TestAccComputeInterconnect_computeInterconnectMacsecTest [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Added support for application awareness on interconnect and added an …

ec86f73

…update test.

github-actions bot requested a review from rileykarson June 13, 2025 08:11

Lint fix

5d2d4da

modular-magician added the service/compute-interconnect label Jun 13, 2025

Adding version guards

35f2f29

Feature guarded subfields

0ebb389

fix unit test for google provider error

f986349

changed the suffix to .go.tmpl instead of .go

767eef4

Corrected the payload

3fc42bd

abhijeetkjha-google added 2 commits June 18, 2025 19:33

changed resource name

a3135b4

changed interconnect-locations

17e7a2c

typo

b5ac06e

Added support for application awareness on interconnect #14267

Are you sure you want to change the base?

Added support for application awareness on interconnect #14267

Conversation

abhijeetkjha-google commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 13, 2025

Uh oh!

modular-magician commented Jun 13, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 13, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 13, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 13, 2025

Uh oh!

modular-magician commented Jun 13, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 13, 2025

Uh oh!

modular-magician commented Jun 13, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 13, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 13, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

modular-magician commented Jun 18, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 18, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 18, 2025

Uh oh!

modular-magician commented Jun 18, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 18, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 18, 2025

Uh oh!

modular-magician commented Jun 18, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 18, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 18, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 18, 2025

Uh oh!

modular-magician commented Jun 18, 2025

Tests analytics

Uh oh!

modular-magician commented Jun 18, 2025

Uh oh!

modular-magician commented Jun 18, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Jun 18, 2025

Diff report

abhijeetkjha-google commented Jun 13, 2025 •

edited

Loading