Skip to content

Comments

Update google.golang.org/api package to the latest version#14276

Merged
c2thorn merged 1 commit intoGoogleCloudPlatform:mainfrom
kautikdk:api_module_version_update
Jun 17, 2025
Merged

Update google.golang.org/api package to the latest version#14276
c2thorn merged 1 commit intoGoogleCloudPlatform:mainfrom
kautikdk:api_module_version_update

Conversation

@kautikdk
Copy link
Member

@kautikdk kautikdk commented Jun 13, 2025 •
edited by c2thorn
Loading

This PR updates google.golang.org/api package to the version v0.237.0.
Followed steps mentioned in this documentation: https://googlecloudplatform.github.io/magic-modules/develop/update-dependencies/

Ran go get google.golang.org/api@latest and go mod tidy to get the latest version of the package.

provider: updated google.golang.org/api to v0.237.0

@github-actions github-actions bot requested a review from c2thorn June 13, 2025 19:36
@github-actions
Copy link

github-actions bot commented Jun 13, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 13, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 63 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 2 files changed, 63 insertions(+), 63 deletions(-))

c2thorn
c2thorn reviewed Jun 13, 2025
View reviewed changes
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what API service(s) is this version bump intended for?

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 13, 2025

Tests analytics

Total tests: 5293
Passed tests: 4677
Skipped tests: 585
Affected tests: 31

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 31 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccLoggingFolderSettings_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 13, 2025

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Error message] [Debug log]
TestAccContainerNodePool_autoscaling [Error message] [Debug log]
TestAccContainerNodePool_fastSocket [Error message] [Debug log]
TestAccContainerNodePool_gcfsConfig [Error message] [Debug log]
TestAccContainerNodePool_gvnic [Error message] [Debug log]
TestAccContainerNodePool_privateRegistry [Error message] [Debug log]
TestAccContainerNodePool_regionalAutoscaling [Error message] [Debug log]
TestAccContainerNodePool_resize [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccContainerNodePool_totalSize [Error message] [Debug log]
TestAccContainerNodePool_version [Error message] [Debug log]
TestAccContainerNodePool_withCgroupMode [Error message] [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Error message] [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Error message] [Debug log]
TestAccContainerNodePool_withHugepageConfig [Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig [Error message] [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Error message] [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Error message] [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Error message] [Debug log]
TestAccContainerNodePool_withManagement [Error message] [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Error message] [Debug log]
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]
TestAccContainerNodePool_withNodeConfig [Error message] [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Error message] [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Error message] [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@kautikdk
Copy link
Member Author

kautikdk commented Jun 15, 2025

what API service(s) is this version bump intended for?

Storage service, reference: b/421973501.

@github-actions github-actions bot requested a review from c2thorn June 15, 2025 11:24
@kautikdk
Copy link
Member Author

kautikdk commented Jun 16, 2025

Hi @c2thorn, Can we please prioritize review of this PR? It's blocking one critical feature GA.

c2thorn
c2thorn reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of failing tests, rerunning to try to eliminate flakes

@c2thorn
Copy link
Member

c2thorn commented Jun 17, 2025

/gcbrun

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 17, 2025

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 63 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 2 files changed, 63 insertions(+), 63 deletions(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 17, 2025

Tests analytics

Total tests: 5302
Passed tests: 4690
Skipped tests: 586
Affected tests: 26

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 26 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Jun 17, 2025

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_resourceManagerTags [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

c2thorn
c2thorn approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that the failing VCR tests were already failing in the nightly builds.

@c2thorn c2thorn added this pull request to the merge queue Jun 17, 2025
Merged via the queue into GoogleCloudPlatform:main with commit c4ab3b8 Jun 17, 2025
24 of 25 checks passed
This was referenced Jun 17, 2025
Merged
Merged
kautikdk added a commit to kautikdk/magic-modules that referenced this pull request Jun 18, 2025
@kautikdk
Update google.golang.org/api package to the latest version (GoogleClo…
92740b2 
…udPlatform#14276)
G-jackyli pushed a commit to G-jackyli/magic-modules that referenced this pull request Jun 21, 2025
@kautikdk @G-jackyli
Update google.golang.org/api package to the latest version (GoogleClo…
78325b5 
…udPlatform#14276)
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Jun 23, 2025
@kautikdk @niharika-98
Update google.golang.org/api package to the latest version (GoogleClo…
0d4e304 
…udPlatform#14276)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
@kautikdk @BBBmau
Update google.golang.org/api package to the latest version (GoogleClo…
d7271cf 
…udPlatform#14276)
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
@kautikdk @jingqizz
Update google.golang.org/api package to the latest version (GoogleClo…
3771f3f 
…udPlatform#14276)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
@kautikdk @BBBmau
Update google.golang.org/api package to the latest version (GoogleClo…
ea6740b 
…udPlatform#14276)
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
@kautikdk @NandiniAgrawal15
Update google.golang.org/api package to the latest version (GoogleClo…
35732ad 
…udPlatform#14276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c2thorn c2thorn c2thorn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kautikdk @modular-magician @c2thorn