new-resource: google_apigee_security_action

[ramonvermeulen]

Closes hashicorp/terraform-provider-google#23241

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_apigee_security_action`

[ramonvermeulen]

Acceptance tests pass locally:

❮ make testacc TEST=./google/services/apigee TESTARGS='-run=TestAccApigeeSecurityAction_'

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/apigee -v -run=TestAccApigeeSecurityAction_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample
=== PAUSE TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample
=== CONT  TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample
--- PASS: TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample (630.15s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/apigee   630.869s

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1492 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1492 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 362 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_security_action (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_security_action" "primary" {
  api_proxies = # value needed
  condition_config {
    access_tokens  = # value needed
    api_keys       = # value needed
    api_products   = # value needed
    asns           = # value needed
    developer_apps = # value needed
    developers     = # value needed
    http_methods   = # value needed
    region_codes   = # value needed
    user_agents    = # value needed
  }
  deny {
    response_code = # value needed
  }
  flag {
    headers {
      name  = # value needed
      value = # value needed
    }
  }
  ttl = # value needed
}

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 20
Skipped tests: 41
Affected tests: 1

Click here to see the affected service packages

• apigee

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

@modular-magician reassign-reviewer

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1490 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1490 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 362 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_security_action (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_security_action" "primary" {
  api_proxies = # value needed
  condition_config {
    access_tokens  = # value needed
    api_keys       = # value needed
    api_products   = # value needed
    asns           = # value needed
    developer_apps = # value needed
    developers     = # value needed
    http_methods   = # value needed
    region_codes   = # value needed
    user_agents    = # value needed
  }
  deny {
    response_code = # value needed
  }
  flag {
    headers {
      name  = # value needed
      value = # value needed
    }
  }
  ttl = # value needed
}

[ScottSuarez]

Could we add another testcase to cover as many fields as possible. I realize some of these fields cannot cover for one reason or another.

[modular-magician]

Tests analytics

Total tests: 62
Passed tests: 20
Skipped tests: 41
Affected tests: 1

Click here to see the affected service packages

• apigee

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccApigeeSecurityAction_apigeeSecurityActionBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@ramonvermeulen, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[ramonvermeulen]

Could we add another testcase to cover as many fields as possible. I realize some of these fields cannot cover for one reason or another.

Sorry for the late reply, been busy and have been OOO for a while.

Just updated with a full test case in 3e949ba, only annoying part is that a lot of properties are mutually exclusive, but I think I now covered them all via in-place updates.

Test execution:

❯ make testacc TEST=./google/services/apigee TESTARGS='-run=TestAccApigeeSecurityAction_apigeeSecurityActionFull'

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/apigee -v -run=TestAccApigeeSecurityAction_apigeeSecurityActionFull -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccApigeeSecurityAction_apigeeSecurityActionFull
=== PAUSE TestAccApigeeSecurityAction_apigeeSecurityActionFull
=== CONT  TestAccApigeeSecurityAction_apigeeSecurityActionFull
--- PASS: TestAccApigeeSecurityAction_apigeeSecurityActionFull (1107.71s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/apigee   1108.440s

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1944 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1944 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 362 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_security_action (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_security_action" "primary" {
  api_proxies = # value needed
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeSecurityAction_apigeeSecurityActionFull

Tests analytics

Total tests: 66
Passed tests: 24
Skipped tests: 42
Affected tests: 0

Click here to see the affected service packages

• apigee

🟢 All tests passed!

View the build log