-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added wait after service enablement in tests :Bug 394920780 #14513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added wait after service enablement in tests :Bug 394920780 #14513
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 61 Click here to see the affected service packages
View the build log |
@Lavanya-Polipalli, can you complete CLA https://github.com/GoogleCloudPlatform/magic-modules/pull/14513/checks?check_run_id=45842379099? Thanks. |
Also, can you confirm that the test |
@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to confirm the test is fixed locally.
Yes, The test is fixed locally. |
@Lavanya-Polipalli, thanks for the confirmation. Can you please share the test logs in gpaste? Thanks. |
I run the test TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicTestExample in CI and it failed with this error
Can you try to modify this line in the yaml file to the following?
After this change, we will run the test again to see if it passes or not. |
fixes hashicorp/terraform-provider-google#21181