Skip to content

Added wait after service enablement in tests :Bug 394920780 #14513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lavanya-Polipalli
Copy link

@Lavanya-Polipalli Lavanya-Polipalli commented Jul 12, 2025

Copy link

google-cla bot commented Jul 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 July 12, 2025 04:28
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/apigee and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 12, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 insertions(+))
google-beta provider: Diff ( 1 file changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 61
Passed tests: 20
Skipped tests: 41
Affected tests: 0

Click here to see the affected service packages
  • apigee
🟢 All tests passed!

View the build log

@zli82016
Copy link
Member

@zli82016
Copy link
Member

Also, can you confirm that the test TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicTestExample is fixed locally? Thanks.

Copy link

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to confirm the test is fixed locally.

@Lavanya-Polipalli
Copy link
Author

Yes, The test is fixed locally.
Thanks

@github-actions github-actions bot requested a review from zli82016 July 18, 2025 15:52
@zli82016
Copy link
Member

@Lavanya-Polipalli, thanks for the confirmation. Can you please share the test logs in gpaste? Thanks.

@zli82016
Copy link
Member

I run the test TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicTestExample in CI and it failed with this error

Error: Error waiting to create HealthCheck: Error waiting for Creating HealthCheck: error while retrieving operation: googleapi: Error 403: Compute Engine API has not been used in project tf-testtn4ds1pv4x before or it is disabled. 

Can you try to modify this line in the yaml file to the following?

  depends_on = [time_sleep.wait_120_seconds]

After this change, we will run the test again to see if it passes or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicTestExample
3 participants