Add HA Policy to Regional Backend Services

[uberferg]

Adds Terraform support for HA Policy as per http://b/353278740 and hashicorp/terraform-provider-google#22615

Release Note Template for Downstream PRs (will be copied)

compute: added `ha_policy` field to `google_compute_region_backend_service` resource

[slevenick]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 356 insertions(+))
google-beta provider: Diff ( 4 files changed, 356 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_backend_service (178 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  ha_policy {
    leader {
      backend_group = # value needed
      network_endpoint {
        instance = # value needed
      }
    }
  }
}

[uberferg]

I noticed the bot added the "compute-l7-load-balancer" label, but this change is not for L7LB. I think the label should be "compute-regional-pass-through-lb".

Seems the bot did the same thing on the issue I created a while ago (hashicorp/terraform-provider-google#22615) and I didn't notice. Not sure how to change the label in either location though...

[modular-magician]

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

• compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 538 insertions(+))
google-beta provider: Diff ( 4 files changed, 538 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 289 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1259
Passed tests: 1172
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

• compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeaderExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeaderExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 538 insertions(+))
google-beta provider: Diff ( 4 files changed, 538 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 289 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1259
Passed tests: 1172
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

• compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeaderExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeaderExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test