Skip to content

Autoallocation options support for networkconnectivity InternalRange #14526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sebkalis
Copy link
Contributor

A new allocation options block was added to networkconnectivity.InternalRange resource. The block contains allocation_strategy enum and first_available_range_lookup_size int parameter.

Fixes hashicorp/terraform-provider-google#23611

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkconnectivity: added field `allocation_options` to resource `google_network_connectivity_internal_range`

@github-actions github-actions bot requested a review from roaks3 July 15, 2025 09:14
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 277 insertions(+))
google-beta provider: Diff ( 4 files changed, 277 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 239 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 41
Passed tests: 38
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • networkconnectivity
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAllocationAlgoritmsExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAllocationAlgoritmsRandomFirstNExample

Get to know how VCR tests work

@sebkalis sebkalis marked this pull request as draft July 15, 2025 09:30
@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAllocationAlgoritmsExample [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAllocationAlgoritmsRandomFirstNExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 277 insertions(+))
google-beta provider: Diff ( 4 files changed, 277 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 239 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 41
Passed tests: 40
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity
🟢 All tests passed!

View the build log

@sebkalis sebkalis marked this pull request as ready for review July 15, 2025 10:17
Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for allocation options to InternalRange resources in network connectivity product
2 participants