Router tags at creation #14527

Gorlami96 · 2025-07-15T09:31:15Z

Router tagging at creation Hz - b/323924842
Release Note Template for Downstream PRs (will be copied)

compute: add `params.resourceManagerTags` field to the `google_compute_router`

github-actions · 2025-07-15T09:32:15Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-07-15T09:44:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 174 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-15T09:51:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 174 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-15T10:11:23Z

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-15T10:12:00Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-15T10:18:57Z

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-15T10:19:13Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-15T11:13:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 45 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 172 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-15T11:31:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 44 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 172 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-15T11:40:16Z

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-15T11:40:31Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-15T12:00:06Z

Tests analytics

Total tests: 1255
Passed tests: 1168
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-15T12:00:21Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/third_party/terraform/services/compute/resource_compute_router_test.go.tmpl

rileykarson · 2025-07-15T18:07:36Z

mmv1/third_party/terraform/services/compute/resource_compute_router_test.go.tmpl

+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),


Suggested change

ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),

ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),

The new params field being tested is only available in beta. Will using ProtoV5ProviderFactories work?

Yes! The standard factory aliases the beta provider as google in the test when run from the beta provider repo, while the BetaFactories factory uses its external google-beta alias. This only matters for examples where we want to use the appropriate external alias, and tests can use the google one for ease of promotion later.

Not sure but the test starts failing with Inconsistent Lock file error when this is changed to ProtoV5ProviderFactories. So leaving this as it is for now.

modular-magician · 2025-07-16T11:52:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 138 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-16T12:21:45Z

Tests analytics

Total tests: 1256
Passed tests: 1169
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-16T12:22:02Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

zli82016 · 2025-07-16T17:05:17Z

/gcbrun

modular-magician · 2025-07-16T17:19:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 138 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-16T17:50:18Z

Tests analytics

Total tests: 1256
Passed tests: 1169
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-16T17:50:35Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-17T08:15:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 141 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-17T08:43:33Z

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-17T08:43:50Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-17T09:55:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 141 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-17T10:25:04Z

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-17T10:26:27Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/third_party/terraform/services/compute/resource_compute_router_test.go.tmpl

modular-magician · 2025-07-18T11:09:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 140 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-18T11:37:03Z

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-18T11:37:18Z

🔴 Tests failed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…k file

modular-magician · 2025-07-21T10:22:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 14 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 140 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician · 2025-07-21T10:49:38Z

Tests analytics

Total tests: 1258
Passed tests: 1171
Skipped tests: 86
Affected tests: 1

Click here to see the affected service packages

compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRouter_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2025-07-21T10:52:50Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRouter_resourceManagerTags [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Gorlami96 added 2 commits July 14, 2025 12:45

Add router tagging at creation

58ceafe

Fixing typos in test

a7d9c77

github-actions bot requested a review from rileykarson July 15, 2025 09:32

Fixing lint errors

90f92f4

modular-magician added the service/compute-router label Jul 15, 2025

fixing tests

77bb893

correcting import to be only for beta

cf8131c

rileykarson reviewed Jul 15, 2025

View reviewed changes

Adding import for compute router test

ecc8c9c

github-actions bot requested a review from rileykarson July 16, 2025 11:40

Changing provider to beta

43cd3f1

Fixing resource names

f338827

rileykarson reviewed Jul 17, 2025

View reviewed changes

mmv1/third_party/terraform/services/compute/resource_compute_router_test.go.tmpl Outdated Show resolved Hide resolved

mmv1/third_party/terraform/services/compute/resource_compute_router_test.go.tmpl Show resolved Hide resolved

Responding to PR comments

b962573

github-actions bot requested a review from rileykarson July 18, 2025 10:56

Changing back to ProtoV5ProviderBetaFactories due to inconsistent loc…

8d39c51

…k file

	ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
	ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),

Router tags at creation #14527

Are you sure you want to change the base?

Router tags at creation #14527

Conversation

Gorlami96 commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

modular-magician commented Jul 15, 2025

Diff report

Uh oh!

modular-magician commented Jul 15, 2025

Diff report

Uh oh!

modular-magician commented Jul 15, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 15, 2025

Uh oh!

modular-magician commented Jul 15, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 15, 2025

Uh oh!

modular-magician commented Jul 15, 2025

Diff report

Uh oh!

modular-magician commented Jul 15, 2025

Diff report

Uh oh!

modular-magician commented Jul 15, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 15, 2025

Uh oh!

modular-magician commented Jul 15, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 15, 2025

Uh oh!

Uh oh!

rileykarson Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Gorlami96 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rileykarson Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Gorlami96 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jul 16, 2025

Diff report

Uh oh!

modular-magician commented Jul 16, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 16, 2025

Uh oh!

zli82016 commented Jul 16, 2025

Uh oh!

modular-magician commented Jul 16, 2025

Diff report

Uh oh!

modular-magician commented Jul 16, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 16, 2025

Uh oh!

modular-magician commented Jul 17, 2025

Diff report

Uh oh!

modular-magician commented Jul 17, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 17, 2025

Uh oh!

Gorlami96 commented Jul 15, 2025 •

edited

Loading