Skip to content

Remove configmanagement.binauthz field in google_gke_hub_feature_membership #14531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: FEATURE-BRANCH-major-release-7.0.0
Choose a base branch
from

Conversation

haiyanmeng
Copy link
Contributor

@haiyanmeng haiyanmeng commented Jul 15, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

gkehub: removed `configmanagement.binauthz` field in `google_gke_hub_feature_membership`

@github-actions github-actions bot requested a review from melinath July 15, 2025 16:12
Copy link

github-actions bot commented Jul 15, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@haiyanmeng
Copy link
Contributor Author

/assign @c2thorn

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 6 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 6 insertions(+), 13 deletions(-))

…mbership

This also changes the title in file
`gke_hub_feature_membership.html.markdown` to match the resource name.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 7 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 3 files changed, 7 insertions(+), 14 deletions(-))

@melinath
Copy link
Member

Sounds like @c2thorn may have specific context, reassigning.

@modular-magician reassign-reviewer @c2thorn

@github-actions github-actions bot requested review from c2thorn and removed request for melinath July 15, 2025 20:49
Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants