Skip to content

Add deletion policy to Secure Source Manager repository #14532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericpang777
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

securesourcemanager: added `deletion_policy` field to `google_secure_source_manager_repository` resource

@github-actions github-actions bot requested a review from c2thorn July 15, 2025 17:37
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 57 insertions(+), 46 deletions(-))
google-beta provider: Diff ( 7 files changed, 57 insertions(+), 46 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 6 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securesourcemanager
🟢 All tests passed!

View the build log

@ericpang777
Copy link
Contributor Author

@c2thorn Hi could you take a look? I would like this change to be in the same release as #14454 so it doesn't make the docs ugly (one resource has deletion policy, the other has lifecycle rules)

Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants