Skip to content

Add a resource google_discovery_engine_recommendation_engine #14538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jialei-chen
Copy link
Member

Fixes hashicorp/terraform-provider-google#18806

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_discovery_engine_recommendation_engine`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1573 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1573 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 297 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 252 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_recommendation_engine (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_recommendation_engine" "primary" {
  media_recommendation_engine_config {
    engine_features_config {
      most_popular_config {
        time_window_days = # value needed
      }
    }
    optimization_objective_config {
      target_field             = # value needed
      target_field_value_float = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 17
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • discoveryengine
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineRecommendationEngine_discoveryengineRecommendationengineGenericExample
  • TestAccDiscoveryEngineRecommendationEngine_discoveryengineRecommendationengineMediaExample
  • TestAccDiscoveryEngineRecommendationEngine_discoveryengineRecommendationengineMediaExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineRecommendationEngine_discoveryengineRecommendationengineGenericExample [Debug log]
TestAccDiscoveryEngineRecommendationEngine_discoveryengineRecommendationengineMediaExample [Debug log]
TestAccDiscoveryEngineRecommendationEngine_discoveryengineRecommendationengineMediaExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating Recommendation Apps on Agent Builder via Terraform (SOLUTION_TYPE_RECOMMENDATION)
2 participants