New resource: google_apigee_api_product

[rickygodoy]

Adding a first version for the Apigee API Product.

`google_apigee_api_product`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 4005 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 4005 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 823 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_api_product (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_api_product" "primary" {
  space = # value needed
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeApiProduct_apigeeApiProduct_full

Tests analytics

Total tests: 65
Passed tests: 20
Skipped tests: 42
Affected tests: 3

Click here to see the affected service packages

• apigee

#### Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeApiProduct_apigeeApiProductBasicTestExample
• TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample
• TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Debug log]
TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductBasicTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[rickygodoy]

🟢 Tests passed during RECORDING mode: TestAccApigeeApiProduct_apigeeApiProductWithAttributesTestExample [Debug log] TestAccApigeeApiProduct_apigeeApiProductWithLegacyOperationTestExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccApigeeApiProduct_apigeeApiProductBasicTestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Error: Error waiting to create Instance: Error waiting for Creating Instance: Error code 13, message: Internal error during operation. Please retry the operation. If the error persists, please contact Apigee support

This one seems like an intermittent error, the other tests create the same instance.

[rickygodoy]

The space property cannot be tested right now, it's a new option and we don't have the resource for its creation.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 4006 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 4006 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 823 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_api_product (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_api_product" "primary" {
  space = # value needed
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccApigeeApiProduct_apigeeApiProduct_full

Tests analytics

Total tests: 65
Passed tests: 22
Skipped tests: 42
Affected tests: 1

Click here to see the affected service packages

• apigee

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeApiProduct_apigeeApiProductBasicTestExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProductBasicTestExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[SirGitsalot]

Mostly LGTM, just one change and a question. I kicked off the tests on our nightly CI system for a full, non-VCR test run.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 4005 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 4005 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 823 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_api_product (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_api_product" "primary" {
  space = # value needed
}

[modular-magician]

Tests analytics

Total tests: 65
Passed tests: 23
Skipped tests: 41
Affected tests: 1

Click here to see the affected service packages

• apigee

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeApiProduct_apigeeApiProduct_full

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApigeeApiProduct_apigeeApiProduct_full [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test