Skip to content

Apply the labels model in google_monitoring_notification_channel resource #14553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: FEATURE-BRANCH-major-release-7.0.0
Choose a base branch
from

Conversation

zli82016
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 262 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 6 files changed, 262 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 262 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 6 files changed, 262 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5355
Passed tests: 4707
Skipped tests: 588
Affected tests: 60

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 60 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample
  • TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID
  • TestAccBillingBudget_billingBudgetNotifyExample
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique
  • TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel
  • TestAccDialogflowCXFlow_dialogflowcxFlowFullExample
  • TestAccDialogflowCXPage_dialogflowcxPageFullExample
  • TestAccDialogflowCXPage_update
  • TestAccDialogflowCXTool_dialogflowcxToolDataStoreExample
  • TestAccDialogflowCXWebhook_update
  • TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample
  • TestAccGeminiGeminiGcpEnablementSettingBinding_update
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccLoggingFolderSettings_update
  • TestAccModelArmorTemplate_basic
  • TestAccModelArmorTemplate_modelarmorTemplateBasicExample
  • TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample
  • TestAccModelArmorTemplate_modelarmorTemplateLabelExample
  • TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample
  • TestAccModelArmorTemplate_update
  • TestAccMonitoringNotificationChannel_notificationChannelBasicExample
  • TestAccMonitoringNotificationChannel_update
  • TestAccMonitoringNotificationChannel_updateLabels
  • TestAccMonitoringNotificationChannel_updateSensitiveLabels
  • TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update
  • TestAccRedisInstance_redisInstanceFullExample
  • TestAccRedisInstance_redisInstanceMrrExample
  • TestAccRedisInstance_redisInstancePrivateServiceTestExample
  • TestAccStorageObject_content

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5355
Passed tests: 4710
Skipped tests: 588
Affected tests: 57

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 57 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample
  • TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID
  • TestAccBillingBudget_billingBudgetNotifyExample
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique
  • TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel
  • TestAccDialogflowCXFlow_dialogflowcxFlowFullExample
  • TestAccDialogflowCXPage_dialogflowcxPageFullExample
  • TestAccDialogflowCXPage_update
  • TestAccDialogflowCXTool_dialogflowcxToolDataStoreExample
  • TestAccDialogflowCXWebhook_update
  • TestAccGeminiGeminiGcpEnablementSettingBinding_update
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample
  • TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccModelArmorTemplate_basic
  • TestAccModelArmorTemplate_modelarmorTemplateBasicExample
  • TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample
  • TestAccModelArmorTemplate_modelarmorTemplateLabelExample
  • TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample
  • TestAccModelArmorTemplate_update
  • TestAccMonitoringNotificationChannel_notificationChannelBasicExample
  • TestAccMonitoringNotificationChannel_update
  • TestAccMonitoringNotificationChannel_updateLabels
  • TestAccMonitoringNotificationChannel_updateSensitiveLabels
  • TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update
  • TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update
  • TestAccRedisInstance_redisInstanceFullExample
  • TestAccRedisInstance_redisInstanceMrrExample
  • TestAccRedisInstance_redisInstancePrivateServiceTestExample
  • TestAccStorageObject_content

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gcfsConfig [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withManagement [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDialogflowCXFlow_dialogflowcxFlowFullExample [Debug log]
TestAccDialogflowCXPage_dialogflowcxPageFullExample [Debug log]
TestAccDialogflowCXPage_update [Debug log]
TestAccDialogflowCXTool_dialogflowcxToolDataStoreExample [Debug log]
TestAccDialogflowCXWebhook_update [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Debug log]
TestAccGeminiGeminiGcpEnablementSettingBinding_update [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update [Debug log]
TestAccLoggingFolderSettings_update [Debug log]
TestAccModelArmorTemplate_basic [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateBasicExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateLabelExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample [Debug log]
TestAccModelArmorTemplate_update [Debug log]
TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update [Debug log]
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Debug log]
TestAccRedisInstance_redisInstancePrivateServiceTestExample [Debug log]
TestAccStorageObject_content [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]
TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample [Error message] [Debug log]
TestAccBillingBudget_billingBudgetNotifyExample [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccMonitoringNotificationChannel_notificationChannelBasicExample [Error message] [Debug log]
TestAccMonitoringNotificationChannel_update [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateLabels [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateSensitiveLabels [Error message] [Debug log]
TestAccRedisInstance_redisInstanceFullExample [Error message] [Debug log]
TestAccRedisInstance_redisInstanceMrrExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID [Debug log]
TestAccContainerNodePool_autoscaling [Debug log]
TestAccContainerNodePool_fastSocket [Debug log]
TestAccContainerNodePool_gvnic [Debug log]
TestAccContainerNodePool_privateRegistry [Debug log]
TestAccContainerNodePool_resize [Debug log]
TestAccContainerNodePool_totalSize [Debug log]
TestAccContainerNodePool_version [Debug log]
TestAccContainerNodePool_withCgroupMode [Debug log]
TestAccContainerNodePool_withConfidentialNodes [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log]
TestAccContainerNodePool_withHugepageConfig [Debug log]
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]
TestAccContainerNodePool_withMaxRunDuration [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withNodeConfig [Debug log]
TestAccContainerNodePool_withTaintsUpdate [Debug log]
TestAccContainerNodePool_withUpgradeSettings [Debug log]
TestAccContainerNodePool_withWindowsNodeConfig [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]
TestAccDialogflowCXTool_dialogflowcxToolDataStoreExample [Debug log]
TestAccDialogflowCXWebhook_update [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample [Debug log]
TestAccGeminiGeminiGcpEnablementSetting_geminiGeminiGcpEnablementSettingBasicExample_update [Debug log]
TestAccModelArmorTemplate_basic [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateBasicExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateFilterConfigExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateLabelExample [Debug log]
TestAccModelArmorTemplate_modelarmorTemplateTemplateMetadataExample [Debug log]
TestAccModelArmorTemplate_update [Debug log]
TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update [Debug log]
TestAccNetappStoragePool_flexAutoTierStoragePoolCreateExample_update [Debug log]
TestAccRedisInstance_redisInstanceFullExample [Debug log]
TestAccRedisInstance_redisInstanceMrrExample [Debug log]
TestAccRedisInstance_redisInstancePrivateServiceTestExample [Debug log]
TestAccStorageObject_content [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteAptExample [Error message] [Debug log]
TestAccBillingBudget_billingBudgetNotifyExample [Error message] [Debug log]
TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel [Error message] [Debug log]
TestAccDialogflowCXFlow_dialogflowcxFlowFullExample [Error message] [Debug log]
TestAccDialogflowCXPage_dialogflowcxPageFullExample [Error message] [Debug log]
TestAccDialogflowCXPage_update [Error message] [Debug log]
TestAccGeminiGeminiGcpEnablementSettingBinding_update [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]
TestAccMonitoringNotificationChannel_notificationChannelBasicExample [Error message] [Debug log]
TestAccMonitoringNotificationChannel_update [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateLabels [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateSensitiveLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 246 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 6 files changed, 246 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 246 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 6 files changed, 246 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 46
Skipped tests: 3
Affected tests: 9

Click here to see the affected service packages
  • monitoring
#### Action taken
Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique
  • TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel
  • TestAccMonitoringNotificationChannel_notificationChannelBasicExample
  • TestAccMonitoringNotificationChannel_update
  • TestAccMonitoringNotificationChannel_updateLabels
  • TestAccMonitoringNotificationChannel_updateSensitiveLabels

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 46
Skipped tests: 3
Affected tests: 9

Click here to see the affected service packages
  • monitoring
#### Action taken
Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique
  • TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel
  • TestAccMonitoringNotificationChannel_notificationChannelBasicExample
  • TestAccMonitoringNotificationChannel_update
  • TestAccMonitoringNotificationChannel_updateLabels
  • TestAccMonitoringNotificationChannel_updateSensitiveLabels

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel [Error message] [Debug log]
TestAccMonitoringNotificationChannel_notificationChannelBasicExample [Error message] [Debug log]
TestAccMonitoringNotificationChannel_update [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateLabels [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateSensitiveLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType [Error message] [Debug log]
TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel [Error message] [Debug log]
TestAccMonitoringNotificationChannel_notificationChannelBasicExample [Error message] [Debug log]
TestAccMonitoringNotificationChannel_update [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateLabels [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateSensitiveLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 296 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 8 files changed, 296 insertions(+), 25 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+), 17 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 51
Skipped tests: 3
Affected tests: 4

Click here to see the affected service packages
  • monitoring
#### Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel
  • TestAccMonitoringNotificationChannel_update
  • TestAccMonitoringNotificationChannel_updateLabels
  • TestAccMonitoringNotificationChannel_updateSensitiveLabels

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel [Error message] [Debug log]
TestAccMonitoringNotificationChannel_update [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateLabels [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateSensitiveLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 308 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 8 files changed, 308 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+), 17 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 58
Passed tests: 52
Skipped tests: 3
Affected tests: 3

Click here to see the affected service packages
  • monitoring
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel
  • TestAccMonitoringNotificationChannel_updateLabels
  • TestAccMonitoringNotificationChannel_updateSensitiveLabels

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateLabels [Error message] [Debug log]
TestAccMonitoringNotificationChannel_updateSensitiveLabels [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants