Skip to content

Remove use of ENHANCED performance_monitoring_unit in tests for compute instances #14557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Jul 17, 2025

This was requested by the internal team due to some issues they are currently working through with the setting.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 45 deletions(-))
google-beta provider: Diff ( 3 files changed, 45 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1257
Passed tests: 1168
Skipped tests: 86
Affected tests: 3

Click here to see the affected service packages
  • compute
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceTemplate_performanceMonitoringUnit
  • TestAccComputeInstance_performanceMonitoringUnit
  • TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplate_performanceMonitoringUnit [Debug log]
TestAccComputeInstance_performanceMonitoringUnit [Debug log]
TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@roaks3
Copy link
Contributor Author

roaks3 commented Jul 17, 2025

@modular-magician reassign-reviewer

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn July 17, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants