tgc-revival: support google_blockchain_node_engine_blockchain_nodes #14561
+39
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trodge
commented
Jul 17, 2025
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
zli82016
requested changes
Jul 17, 2025
trodge
commented
Jul 17, 2025
trodge
commented
Jul 17, 2025
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
zli82016
requested changes
Jul 17, 2025
| assetName: //bigquery.googleapis.com/projects/my-project/datasets/my-dataset | ||
| hclData: [project:my-project dataset_id:my-dataset] | ||
| */ | ||
| func ParseUrlParamValuesFromAssetName(assetName string, template string, hclData map[string]any) { |
There was a problem hiding this comment.
It looks like the parsed computed fields need to be filtered out, which is the reason for the test failure.
zli82016
reviewed
Jul 18, 2025
| hclData["project"] = utils.ParseFieldValue(asset.Name, "projects") | ||
| {{- end}} | ||
| {{/* Attempt to parse all self-link parameters from asset name. */}} | ||
| utils.ParseUrlParamValuesFromAssetName(asset.Name, "{{ $.CaiAssetNameTemplate $productBackendName }}", hclData) |
There was a problem hiding this comment.
Also, are there any issues for the previous implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.