Skip to content

tgc-revival: support google_compute_global_address #14562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Jul 17, 2025

Use CaiResourceKind instead of ApiResourceTypeKind for CAI asset type.

Terraform resource: google_compute_address
ApiResourceTypeKind: Address
discovery_name: Address
CaiResourceKind: Address
Cai type: compute.googleapis.com/Address

Terraform resource: google_compute_global_address
ApiResourceTypeKind: Address
discovery_name: Address
CaiResourceKind: GlobalAddress
Cai type: compute.googleapis.com/GlobalAddress

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 7 files changed, 547 insertions(+), 1 deletion(-))

@zli82016 zli82016 marked this pull request as ready for review July 17, 2025 22:45
@zli82016 zli82016 requested a review from trodge July 18, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants