Add support for new flags in Container node kubelet and linux config. #14685

VeraQin · 2025-07-30T05:04:43Z

The new flags in node_kubelet_config include:

eviction_soft
eviction_soft_grace_period
eviction_minimum_reclaim
eviction_max_pod_grace_period_seconds
max_parallel_image_pulls

The new flags in linux_node_config include:

transparent_hugepage_enabled
transparent_hugepage_defrag

The new flags in sole_tenant_config include:

sole_tenant_config

Change-Id: I45c6a35137f532b88380dfd9359f893d25fef859

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `eviction_soft`, `eviction_soft_grace_period`, `eviction_minimum_reclaim`, `eviction_max_pod_grace_period_seconds`, `max_parallel_image_pulls`, `transparent_hugepage_enabled`, `transparent_hugepage_defrag` and `min_node_cpus` to `node_config` block

Change-Id: I45c6a35137f532b88380dfd9359f893d25fef859

github-actions · 2025-07-30T05:05:40Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-07-30T05:16:15Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (464 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    kubelet_config {
      container_log_max_files               = # value needed
      eviction_max_pod_grace_period_seconds = # value needed
      eviction_minimum_reclaim {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft_grace_period {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      max_parallel_image_pulls = # value needed
    }
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
    sole_tenant_config {
      min_node_cpus = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-07-30T05:47:35Z

Tests analytics

Total tests: 241
Passed tests: 226
Skipped tests: 11
Affected tests: 4

Click here to see the affected service packages

container

#### Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withLinuxNodeConfig

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withSoleTenantConfig

Get to know how VCR tests work

modular-magician · 2025-07-30T06:09:53Z

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_withLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerNodePool_withKubeletConfig [Error message] [Debug log]
TestAccContainerNodePool_withSoleTenantConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Change-Id: I45c6a35137f532b88380dfd9359f893d25fef859

modular-magician · 2025-07-30T17:47:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (464 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    kubelet_config {
      container_log_max_files               = # value needed
      eviction_max_pod_grace_period_seconds = # value needed
      eviction_minimum_reclaim {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft_grace_period {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      max_parallel_image_pulls = # value needed
    }
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
    sole_tenant_config {
      min_node_cpus = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-07-30T17:50:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (464 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    kubelet_config {
      container_log_max_files               = # value needed
      eviction_max_pod_grace_period_seconds = # value needed
      eviction_minimum_reclaim {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft_grace_period {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      max_parallel_image_pulls = # value needed
    }
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
    sole_tenant_config {
      min_node_cpus = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-07-30T18:18:24Z

Tests analytics

Total tests: 241
Passed tests: 227
Skipped tests: 11
Affected tests: 3

Click here to see the affected service packages

container

#### Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withSoleTenantConfig

Get to know how VCR tests work

modular-magician · 2025-07-30T18:23:10Z

Tests analytics

Total tests: 241
Passed tests: 227
Skipped tests: 11
Affected tests: 3

Click here to see the affected service packages

container

#### Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withSoleTenantConfig

Get to know how VCR tests work

modular-magician · 2025-07-30T18:40:37Z

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerNodePool_withSoleTenantConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-07-30T18:45:46Z

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerNodePool_withSoleTenantConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

zli82016

Can you fix the missing test coverage in #14685 (comment)?
node_config is also used as google_container_cluster's node_pool.node_config and node_config. Thanks.

Change-Id: Ifac34ff636fa9398e4e523f8a3a01341e73e0cac

modular-magician · 2025-08-03T20:33:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 3 files changed, 404 insertions(+), 26 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (476 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    kubelet_config {
      container_log_max_files               = # value needed
      eviction_max_pod_grace_period_seconds = # value needed
      eviction_minimum_reclaim {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft_grace_period {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      max_parallel_image_pulls = # value needed
    }
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
    sole_tenant_config {
      min_node_cpus = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (106 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-08-03T20:40:35Z

Tests analytics

Total tests: 249
Passed tests: 235
Skipped tests: 11
Affected tests: 3

Click here to see the affected service packages

container

#### Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withKubeletConfig

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withSoleTenantConfig

Get to know how VCR tests work

modular-magician · 2025-08-03T21:01:40Z

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_withKubeletConfig [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerNodePool_withSoleTenantConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-08-03T22:51:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1497 insertions(+), 1004 deletions(-))
google-beta provider: Diff ( 4 files changed, 1536 insertions(+), 1062 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (187 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    kubelet_config {
      container_log_max_files               = # value needed
      eviction_max_pod_grace_period_seconds = # value needed
      eviction_minimum_reclaim {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      eviction_soft_grace_period {
        imagefs_available   = # value needed
        imagefs_inodes_free = # value needed
        memory_available    = # value needed
        nodefs_available    = # value needed
        nodefs_inodes_free  = # value needed
        pid_available       = # value needed
      }
      max_parallel_image_pulls = # value needed
    }
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
    sole_tenant_config {
      min_node_cpus = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (106 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-08-03T22:53:43Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-08-03T23:31:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 499 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 4 files changed, 499 insertions(+), 31 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (476 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    kubelet_config {
      container_log_max_files = # value needed
    }
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (106 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-08-03T23:39:15Z

Tests analytics

Total tests: 249
Passed tests: 233
Skipped tests: 11
Affected tests: 5

Click here to see the affected service packages

container

#### Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates

TestAccContainerCluster_withNodeConfigLinuxNodeConfig

TestAccContainerCluster_withSoleTenantGroup

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withSoleTenantConfig

Get to know how VCR tests work

modular-magician · 2025-08-04T00:00:34Z

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withNodeConfigLinuxNodeConfig [Error message] [Debug log]
TestAccContainerCluster_withSoleTenantGroup [Error message] [Debug log]
TestAccContainerNodePool_withSoleTenantConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-08-04T01:01:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 511 insertions(+), 31 deletions(-))
google-beta provider: Diff ( 4 files changed, 511 insertions(+), 31 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (476 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (106 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-08-04T01:08:24Z

Tests analytics

Total tests: 249
Passed tests: 233
Skipped tests: 11
Affected tests: 5

Click here to see the affected service packages

container

#### Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates

TestAccContainerCluster_withNodeConfigLinuxNodeConfig

TestAccContainerCluster_withSoleTenantGroup

TestAccContainerNodePool_withNetworkConfig

TestAccContainerNodePool_withSoleTenantConfig

Get to know how VCR tests work

modular-magician · 2025-08-04T01:53:44Z

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates [Debug log]
TestAccContainerCluster_withSoleTenantGroup [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]
TestAccContainerNodePool_withSoleTenantConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withNodeConfigLinuxNodeConfig [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Change-Id: I713c178c19947148ce070fb67b2e98be273e6248

VeraQin · 2025-08-04T03:03:33Z

Can you fix the missing test coverage in #14685 (comment)? node_config is also used as google_container_cluster's node_pool.node_config and node_config. Thanks.

Added new flags under test for google_container_cluster.node_config and google_container_node_pool.node_config, which should be sufficient.

modular-magician · 2025-08-04T03:10:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 514 insertions(+), 34 deletions(-))
google-beta provider: Diff ( 4 files changed, 514 insertions(+), 34 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (476 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
  node_pool {
    node_config {
      kubelet_config {
        container_log_max_files               = # value needed
        eviction_max_pod_grace_period_seconds = # value needed
        eviction_minimum_reclaim {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        eviction_soft_grace_period {
          imagefs_available   = # value needed
          imagefs_inodes_free = # value needed
          memory_available    = # value needed
          nodefs_available    = # value needed
          nodefs_inodes_free  = # value needed
          pid_available       = # value needed
        }
        max_parallel_image_pulls = # value needed
      }
      linux_node_config {
        transparent_hugepage_defrag  = # value needed
        transparent_hugepage_enabled = # value needed
      }
      sole_tenant_config {
        min_node_cpus = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (106 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      transparent_hugepage_defrag  = # value needed
      transparent_hugepage_enabled = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_pool.node_config.kubelet_config.eviction_minimum_reclaim node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_pool.node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_pool.node_config.kubelet_config.eviction_soft node_pool.node_config.kubelet_config.eviction_soft.imagefs_available node_pool.node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.memory_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_available node_pool.node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft.pid_available node_pool.node_config.kubelet_config.eviction_soft_grace_period node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.memory_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_pool.node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_pool.node_config.kubelet_config.eviction_soft_grace_period.pid_available node_pool.node_config.kubelet_config.max_parallel_image_pulls node_pool.node_config.linux_node_config.transparent_hugepage_defrag node_pool.node_config.linux_node_config.transparent_hugepage_enabled node_pool.node_config.sole_tenant_config.min_node_cpus]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.kubelet_config.eviction_max_pod_grace_period_seconds node_config.kubelet_config.eviction_minimum_reclaim node_config.kubelet_config.eviction_minimum_reclaim.imagefs_available node_config.kubelet_config.eviction_minimum_reclaim.imagefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.memory_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_available node_config.kubelet_config.eviction_minimum_reclaim.nodefs_inodes_free node_config.kubelet_config.eviction_minimum_reclaim.pid_available node_config.kubelet_config.eviction_soft node_config.kubelet_config.eviction_soft.imagefs_available node_config.kubelet_config.eviction_soft.imagefs_inodes_free node_config.kubelet_config.eviction_soft.memory_available node_config.kubelet_config.eviction_soft.nodefs_available node_config.kubelet_config.eviction_soft.nodefs_inodes_free node_config.kubelet_config.eviction_soft.pid_available node_config.kubelet_config.eviction_soft_grace_period node_config.kubelet_config.eviction_soft_grace_period.imagefs_available node_config.kubelet_config.eviction_soft_grace_period.imagefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.memory_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_available node_config.kubelet_config.eviction_soft_grace_period.nodefs_inodes_free node_config.kubelet_config.eviction_soft_grace_period.pid_available node_config.kubelet_config.max_parallel_image_pulls node_config.linux_node_config.transparent_hugepage_defrag node_config.linux_node_config.transparent_hugepage_enabled node_config.sole_tenant_config.min_node_cpus]

modular-magician · 2025-08-04T03:17:30Z

Tests analytics

Total tests: 249
Passed tests: 236
Skipped tests: 11
Affected tests: 2

Click here to see the affected service packages

container

#### Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withNodeConfigLinuxNodeConfig

TestAccContainerNodePool_withNetworkConfig

Get to know how VCR tests work

modular-magician · 2025-08-04T03:40:10Z

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withNodeConfigLinuxNodeConfig [Debug log]
TestAccContainerNodePool_withNetworkConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

Add support for new flags in Container node kubelet and linux config.

bd75025

Change-Id: I45c6a35137f532b88380dfd9359f893d25fef859

github-actions bot requested a review from zli82016 July 30, 2025 05:05

modular-magician added the service/container label Jul 30, 2025

VeraQin and others added 2 commits July 30, 2025 10:35

Merge branch 'GoogleCloudPlatform:main' into main

32907ca

Add support for new flags in Container node kubelet and linux config.

6adcb21

Change-Id: I45c6a35137f532b88380dfd9359f893d25fef859

zli82016 requested changes Jul 31, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main'

13dc304

Change-Id: Ifac34ff636fa9398e4e523f8a3a01341e73e0cac

github-actions bot requested a review from zli82016 August 3, 2025 20:23

VeraQin force-pushed the main branch from 73bd990 to 4038596 Compare August 3, 2025 23:19

VeraQin force-pushed the main branch from 4038596 to 2918d40 Compare August 4, 2025 00:50

Add new kubelet and linux config flags into cluster test.

d9ccc94

Change-Id: I713c178c19947148ce070fb67b2e98be273e6248

VeraQin force-pushed the main branch from 2918d40 to d9ccc94 Compare August 4, 2025 02:58

Add support for new flags in Container node kubelet and linux config. #14685

Are you sure you want to change the base?

Add support for new flags in Container node kubelet and linux config. #14685

Conversation

VeraQin commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

modular-magician commented Jul 30, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Jul 30, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 30, 2025

Uh oh!

modular-magician commented Jul 30, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Jul 30, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Jul 30, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 30, 2025

Tests analytics

Uh oh!

modular-magician commented Jul 30, 2025

Uh oh!

modular-magician commented Jul 30, 2025

Uh oh!

zli82016 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Aug 3, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Aug 3, 2025

Tests analytics

Uh oh!

modular-magician commented Aug 3, 2025

Uh oh!

modular-magician commented Aug 3, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Aug 3, 2025

Tests analytics

Uh oh!

modular-magician commented Aug 3, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Aug 3, 2025

Tests analytics

Uh oh!

modular-magician commented Aug 4, 2025

Uh oh!

modular-magician commented Aug 4, 2025

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Aug 4, 2025

Tests analytics

Uh oh!

modular-magician commented Aug 4, 2025

VeraQin commented Jul 30, 2025 •

edited

Loading

zli82016 left a comment •

edited

Loading