Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix name of llama tests #1020

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

will-cromar
Copy link
Collaborator

@will-cromar will-cromar commented Dec 5, 2023

Description

The test name currently has the suffix -1vm-1vm. Simplify the test config since there's no 2VM or XRT case to worry about anymore 🎊

Tests

Diff shows just name changes, e.g.

-              cronjob.batch/pt-nightly-llama2-pjrt-infer-func-v4-8-1vm-1vm
-              cronjob.batch/pt-nightly-llama2-pjrt-train-spmd-func-v4-8-1vm-1vm
+              cronjob.batch/pt-nightly-llama2-infer-func-v4-8-1vm
+              cronjob.batch/pt-nightly-llama2-train-spmd-func-v4-8-1vm

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@will-cromar will-cromar marked this pull request as ready for review December 5, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants