fix: Add raw datatype support for Db2 custom queries#1707
Draft
fix: Add raw datatype support for Db2 custom queries#1707
Conversation
…types-custom-query-validations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR solves an issue in our Db2 implementation where we couldn't get the raw data types for custom queries.
Describing the cursor did not reveal the actual data type, only the superset, e.g.
string.We solve the problem in the same way do on Redshift, by creating a view. If a view cannot be created then a warning is output and we fall back to the previous behaviour.
Issues to be closed
Closes #1691
Checklist
CONTRIBUTINGGuide.tests/local_check.shscript)