chore: remove operator cleanup logic #1836
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks like a good change, overall. Let's get the tests passing. |
hsmatulis
force-pushed
the
hsmatulis-rm-cleanupOldResources
branch
from
2492613 to
5749bf7
Compare
b/422809019 Signed-off-by: Henrique Matulis <[email protected]>
hsmatulis
force-pushed
the
hsmatulis-rm-cleanupOldResources
branch
from
5749bf7 to
198df86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the cleanupOldResources logic executed during the operator's startup sequence and its associated unit tests.
Removed cleanupOldResources function from pkg/operator/operator.go.
Removed the call to cleanupOldResources within the main Run loop.
Deleted pkg/operator/operator_test.go as it solely contained TestCleanupOldResources.
Cleaned up unused imports (k8s admissionregistration, apierrors, etc.).
Reasoning
The cleanupOldResources function handled legacy migrations (specifically deleting old ValidatingWebhookConfiguration and unannotated Collector/RuleEvaluator resources). This logic is no longer required for current versions of the operator. Removing it simplifies the startup path and removes technical debt. The only risk would be failure to automatically clear resources upon upgrades
Internal reference: b/422809019