cherrypick#10000
Closed
menahyouyeah wants to merge 381 commits intoGoogleContainerTools:release/v2.7from
Closed
Conversation
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ols#9379) Bumps [flask](https://github.com/pallets/flask) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst) - [Commits](pallets/flask@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: flask dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…eContainerTools#9381) Bumps [flask](https://github.com/pallets/flask) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst) - [Commits](pallets/flask@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: flask dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ContainerTools#9385) Bumps [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign) from 2.2.1 to 2.2.4. - [Release notes](https://github.com/sigstore/cosign/releases) - [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md) - [Commits](sigstore/cosign@v2.2.1...v2.2.4) --- updated-dependencies: - dependency-name: github.com/sigstore/cosign/v2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nerTools#9403) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.2 to 4.3.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@1746f4a...6546280) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…erTools#9402) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.1 to 3.25.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3.25.1...v3.25.2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mands (GoogleContainerTools#9307) * feat(exec|verify): enabled "namespace" option for exec and verify commands * generated doc
…d single quote to the jsonpath (GoogleContainerTools#9448) (GoogleContainerTools#9449)
…nerTools#9468) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…r/config.json when using docker go library (GoogleContainerTools#9469)
* feat: added retry on files sync error * reverted code style changes * fix(dev.go): change package order Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> --------- Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
…loud run job manifest (GoogleContainerTools#9475)
…s#9445) Use bazel logic to determine bazel workspace root and ensure MODULE.bazel is added as a dep to Bazel targets if it is present.
…ntainerTools#9503) * fix: keep the original template if template expansion fails * fix: keep the original template if template expansion fails
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
…ols#9511) Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
…progress (GoogleContainerTools#9476) * feat(kaniko): Optimize kaniko build using compression and add progress Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * add new config for kaniko BuildContextCompressionLevel Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * linters fix Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * fixed defaults_test.go Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> --------- Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
…nerTools#9516) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix minor typo in custom-actions.md * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…es (GoogleContainerTools#9886) * chore: pin some dependencies (and remove some other pins) * chore: go get -u ./... * chore: go mod tidy * chore: go mod vendor * chore: changes required because of docker API incompatibilities
…2 support for rendering since `helm version --client` parameter is not supported anymore in v4 (GoogleContainerTools#9892) * feat(helm): Support Helm v4 for rendering and deployment, drop Helm v2 support for rendering since `helm version --client` parameter is not supported anymore in v4 * Fix imports lint error * Fix lints/tests
Bumps the golang group with 2 updates: [github.com/letsencrypt/boulder](https://github.com/letsencrypt/boulder) and [google.golang.org/api](https://github.com/googleapis/google-api-go-client). Updates `github.com/letsencrypt/boulder` from 0.20251014.0 to 0.20251021.0 - [Release notes](https://github.com/letsencrypt/boulder/releases) - [Changelog](https://github.com/letsencrypt/boulder/blob/main/docs/release.md) - [Commits](letsencrypt/boulder@v0.20251014.0...v0.20251021.0) Updates `google.golang.org/api` from 0.252.0 to 0.253.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.252.0...v0.253.0) --- updated-dependencies: - dependency-name: github.com/letsencrypt/boulder dependency-version: 0.20251021.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: google.golang.org/api dependency-version: 0.253.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… group (GoogleContainerTools#9897) chore: bump actions/upload-artifact in the github-actions group Bumps the github-actions group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/upload-artifact` from 4 to 5 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the golang group with 3 updates: [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go), [github.com/letsencrypt/boulder](https://github.com/letsencrypt/boulder) and [google.golang.org/api](https://github.com/googleapis/google-api-go-client). Updates `cloud.google.com/go/storage` from 1.57.0 to 1.57.1 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@spanner/v1.57.0...storage/v1.57.1) Updates `github.com/letsencrypt/boulder` from 0.20251021.0 to 0.20251027.0 - [Release notes](https://github.com/letsencrypt/boulder/releases) - [Changelog](https://github.com/letsencrypt/boulder/blob/main/docs/release.md) - [Commits](letsencrypt/boulder@v0.20251021.0...v0.20251027.0) Updates `google.golang.org/api` from 0.253.0 to 0.254.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.253.0...v0.254.0) --- updated-dependencies: - dependency-name: cloud.google.com/go/storage dependency-version: 1.57.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: golang - dependency-name: github.com/letsencrypt/boulder dependency-version: 0.20251027.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: google.golang.org/api dependency-version: 0.254.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The OpenJDK containers were removed from dockerhub.
…oogleContainerTools#9903) Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.28 to 1.7.29. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.7.28...v1.7.29) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-version: 1.7.29 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Tools#9863) This change enables Skaffold to push to container image registries that use self-signed or other untrusted certificates, when Skaffold runs on macOS or Windows. It also removes the need for the `SSL_CERT_FILE` environment variable workaround on Linux. Prior to this fix, Skaffold would fail to retrieve the digest from the registry after the image was built, even if the registry was configured as an insecure registry in Skaffold configuration: ``` getting image: Get "https://localhost:8443/v2/": tls: failed to verify certificate: x509: certificate signed by unknown authority; GET http://localhost:8443/v2/: unexpected status code 400 Bad Request: Client sent an HTTP request to an HTTPS server. ``` On Linux environments only, a possible workaround was to set the `SSL_CERT_FILE` environment variable. However, this workaround cannot be used on macOS or Windows. This change updates `getRemoteIndex()` and `getRemoteImage()` in `pkg/skaffold/docker/remote.go`, adding the `InsecureSkipVerify` TLS config field to the transport if the registry from the image name matches one of the insecure registries configured in Skaffold. Fixes: GoogleContainerTools#3039 GoogleContainerTools#3116 Related: google/go-containerregistry#1559
…rTools#9721) * fix: Avoid sync retry if file/directory was not found Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * use os.IsNotExist in dev.go Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * Improve sync error handling in dev.go Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * fix file sync Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> --------- Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Bumps the golang group with 10 updates: | Package | From | To | | --- | --- | --- | | [github.com/docker/cli](https://github.com/docker/cli) | `28.5.1+incompatible` | `28.5.2+incompatible` | | [github.com/docker/docker](https://github.com/docker/docker) | `28.5.1+incompatible` | `28.5.2+incompatible` | | [github.com/letsencrypt/boulder](https://github.com/letsencrypt/boulder) | `0.20251027.0` | `0.20251103.0` | | [github.com/moby/buildkit](https://github.com/moby/buildkit) | `0.25.1` | `0.25.2` | | [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.32.0` | `0.33.0` | | [golang.org/x/sync](https://github.com/golang/sync) | `0.17.0` | `0.18.0` | | [golang.org/x/sys](https://github.com/golang/sys) | `0.37.0` | `0.38.0` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.254.0` | `0.255.0` | | [sigs.k8s.io/kustomize/api](https://github.com/kubernetes-sigs/kustomize) | `0.20.1` | `0.21.0` | | [sigs.k8s.io/kustomize/kyaml](https://github.com/kubernetes-sigs/kustomize) | `0.20.1` | `0.21.0` | Updates `github.com/docker/cli` from 28.5.1+incompatible to 28.5.2+incompatible - [Commits](docker/cli@v28.5.1...v28.5.2) Updates `github.com/docker/docker` from 28.5.1+incompatible to 28.5.2+incompatible - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v28.5.1...v28.5.2) Updates `github.com/letsencrypt/boulder` from 0.20251027.0 to 0.20251103.0 - [Release notes](https://github.com/letsencrypt/boulder/releases) - [Changelog](https://github.com/letsencrypt/boulder/blob/main/docs/release.md) - [Commits](letsencrypt/boulder@v0.20251027.0...v0.20251103.0) Updates `github.com/moby/buildkit` from 0.25.1 to 0.25.2 - [Release notes](https://github.com/moby/buildkit/releases) - [Commits](moby/buildkit@v0.25.1...v0.25.2) Updates `golang.org/x/oauth2` from 0.32.0 to 0.33.0 - [Commits](golang/oauth2@v0.32.0...v0.33.0) Updates `golang.org/x/sync` from 0.17.0 to 0.18.0 - [Commits](golang/sync@v0.17.0...v0.18.0) Updates `golang.org/x/sys` from 0.37.0 to 0.38.0 - [Commits](golang/sys@v0.37.0...v0.38.0) Updates `google.golang.org/api` from 0.254.0 to 0.255.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.254.0...v0.255.0) Updates `sigs.k8s.io/kustomize/api` from 0.20.1 to 0.21.0 - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@api/v0.20.1...api/v0.21.0) Updates `sigs.k8s.io/kustomize/kyaml` from 0.20.1 to 0.21.0 - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@api/v0.20.1...api/v0.21.0) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 28.5.2+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: golang - dependency-name: github.com/docker/docker dependency-version: 28.5.2+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: golang - dependency-name: github.com/letsencrypt/boulder dependency-version: 0.20251103.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: github.com/moby/buildkit dependency-version: 0.25.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: golang - dependency-name: golang.org/x/oauth2 dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: golang.org/x/sync dependency-version: 0.18.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: golang.org/x/sys dependency-version: 0.38.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: google.golang.org/api dependency-version: 0.255.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: sigs.k8s.io/kustomize/api dependency-version: 0.21.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang - dependency-name: sigs.k8s.io/kustomize/kyaml dependency-version: 0.21.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oogleContainerTools#9908) Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/opencontainers/selinux/releases) - [Commits](opencontainers/selinux@v1.12.0...v1.13.0) --- updated-dependencies: - dependency-name: github.com/opencontainers/selinux dependency-version: 1.13.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…backend (GoogleContainerTools#9907) chore: bump rack in /integration/examples/ruby/backend Bumps [rack](https://github.com/rack/rack) from 2.2.14 to 2.2.20. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.14...v2.2.20) --- updated-dependencies: - dependency-name: rack dependency-version: 2.2.20 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: upgrade golang to 1.25.4 * chore: upgrade golang to 1.25.4
* chore: Skaffold 2.17 release * chore: Skaffold 2.17 release
* chore: bump golang.org/x/crypto from 0.43.0 to 0.45.0 (GoogleContainerTools#9917) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump the github-actions group across 1 directory with 3 updates (GoogleContainerTools#9934) Bumps the github-actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/cache](https://github.com/actions/cache) and [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) Updates `actions/cache` from 4 to 5 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) Updates `actions/upload-artifact` from 5 to 6 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: disabling kaniko integration tests due to kaniko service account permissions issue and fix github workflow (GoogleContainerTools#9943) disabling kaniko integration tests due to kaniko service accountpermissioning issue and fix github workflow Co-authored-by: Darien-Lin <darienl@google.com> * chore: upgrade golang to 1.25.5 (GoogleContainerTools#9944) * Upgrade github.com/google/ko to v0.18.1 (GoogleContainerTools#9939) * Upgrade github.com/google/ko to v0.18.1 * Upgrade github.com/google/ko to v0.18.1 continue * fix a issue in docker/auth.go * fix go version issue in test * revert go version changes in test * update docker cli vendor files * Trigger GitHub Actions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Darien Lin <lind3686@gmail.com> Co-authored-by: Darien-Lin <darienl@google.com> Co-authored-by: Chris <chris.ge@live.com>
* chore: bump github.com/sigstore/cosign/v2 from 2.6.1 to 2.6.2 (GoogleContainerTools#9948) Bumps [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign) from 2.6.1 to 2.6.2. - [Release notes](https://github.com/sigstore/cosign/releases) - [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md) - [Commits](sigstore/cosign@v2.6.1...v2.6.2) --- updated-dependencies: - dependency-name: github.com/sigstore/cosign/v2 dependency-version: 2.6.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cicd: bazel github presubmit flow fixes for recent bazel 9.0.0 release (GoogleContainerTools#9961) bazel build fixes for recent bazel 9.0.0 release * chore: bump github.com/sigstore/sigstore from 1.10.3 to 1.10.4 (GoogleContainerTools#9957) Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.10.3 to 1.10.4. - [Release notes](https://github.com/sigstore/sigstore/releases) - [Commits](sigstore/sigstore@v1.10.3...v1.10.4) --- updated-dependencies: - dependency-name: github.com/sigstore/sigstore dependency-version: 1.10.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump github.com/sigstore/rekor from 1.4.3 to 1.5.0 (GoogleContainerTools#9956) Bumps [github.com/sigstore/rekor](https://github.com/sigstore/rekor) from 1.4.3 to 1.5.0. - [Release notes](https://github.com/sigstore/rekor/releases) - [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md) - [Commits](sigstore/rekor@v1.4.3...v1.5.0) --- updated-dependencies: - dependency-name: github.com/sigstore/rekor dependency-version: 1.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.4.1 (GoogleContainerTools#9962) Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.3.0 to 2.4.1. - [Release notes](https://github.com/theupdateframework/go-tuf/releases) - [Commits](theupdateframework/go-tuf@v2.3.0...v2.4.1) --- updated-dependencies: - dependency-name: github.com/theupdateframework/go-tuf/v2 dependency-version: 2.4.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(integration): Update busybox and alpine:3 to use the mirror to avoid docker rate hub limit errors (GoogleContainerTools#9966) test(integration): mirror busybox and alpine:3 images to gcr.io * chore: bump github.com/go-git/go-git/v5 from 5.16.3 to 5.16.5 (GoogleContainerTools#9971) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.16.3 to 5.16.5. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.16.3...v5.16.5) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-version: 5.16.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump golang.org/x/oauth2 from 0.7.0 to 0.27.0 in /examples/grpc-e2e-tests/service (GoogleContainerTools#9918) chore: bump golang.org/x/oauth2 in /examples/grpc-e2e-tests/service Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.7.0 to 0.27.0. - [Commits](golang/oauth2@v0.7.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.27.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump golang.org/x/crypto from 0.36.0 to 0.45.0 in /hack/tools (GoogleContainerTools#9916) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.36.0 to 0.45.0. - [Commits](golang/crypto@v0.36.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Use mirror in Dockerfiles for integration tests to prevent docker hub rate limits (GoogleContainerTools#9970) * use mirror in Dockerfiles for integration tests * use argument prefix instead * fix for multi stage * more fixes * fix buildx-bin error * Bring back comments * missed a comment * chore: upgrade golang to 1.25.7 (GoogleContainerTools#9973) Co-authored-by: Darien-Lin <darienl@google.com> * Updated Dockerfile to try to fix vuln bug (GoogleContainerTools#9974) * Updated Dockerfile to try to fix vuln bug * Addressed the gemini-code-assist comments * Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile . * Updated the node version to fix error (GoogleContainerTools#9976) * Updated Dockerfile to try to fix vuln bug * Addressed the gemini-code-assist comments * Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile . * Updated node version to try and fix error * chore: fixing docs due to upgrade in Hugo (GoogleContainerTools#9977) fixing docs due to upgrade in Hugo --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: menahyouyeah <minnah@google.com> Co-authored-by: Darien-Lin <darienl@google.com> Co-authored-by: ruhi-chaddha <ruhichaddha@google.com>
delete webhooks used to display what the docs would look like with a PR change
…ntainerTools#9993) Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.6.1 to 1.6.3. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.6.1...v1.6.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-version: 1.6.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* debug migrating to Kokoro instances - pared down PR * switch to new project in presubmit.sh * pared down to just one test * tag skaffold-builder image with commit and push to AR * use buildx with --load * jib errors * remove wrong project * jib updates
…load/python (GoogleContainerTools#9989) chore: bump flask in /integration/examples/hot-reload/python Bumps [flask](https://github.com/pallets/flask) from 2.2.5 to 3.1.3. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst) - [Commits](pallets/flask@2.2.5...3.1.3) --- updated-dependencies: - dependency-name: flask dependency-version: 3.1.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…gleContainerTools#9981) Bumps [rack](https://github.com/rack/rack) from 2.2.20 to 2.2.22. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.20...v2.2.22) --- updated-dependencies: - dependency-name: rack dependency-version: 2.2.22 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a comprehensive set of updates, including new features, bug fixes, and dependency upgrades, to enhance Skaffold's functionality and maintainability. It refines the build and deployment experience by updating core tools, improving configuration flexibility, and providing clearer feedback mechanisms. The changes also focus on streamlining internal processes and ensuring documentation accurately reflects the current state of the project. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a large cherry-pick of numerous commits, introducing a wide range of changes including new features, bug fixes, dependency upgrades, and documentation improvements. Key changes include updating many dependencies and tools, removing the 'survey' and 'skaffold slim' features, and adding new capabilities like GCS remote config dependencies and Bazel platform mappings. The review focused on the correctness of these varied changes. A minor but important typo was found in a new user-facing error message and its corresponding tests, where a Cyrillic character was used instead of a Latin one. The rest of the changes appear to be correct and consistent with the goals described in the commit messages.
Note: Security Review did not run due to the size of the PR.
| } | ||
| if contextConfig == nil { // empty config | ||
| if contextConfig == nil { | ||
| fmt.Fprintf(out, "No config found for сurrent context %q\n", kubecontext) |
Contributor
There was a problem hiding this comment.
There's a typo in the word "current". It's using a Cyrillic 'с' (U+0441) instead of a Latin 'c'. This should be corrected to avoid potential rendering or processing issues.
Suggested change
| fmt.Fprintf(out, "No config found for сurrent context %q\n", kubecontext) | |
| fmt.Fprintf(out, "No config found for current context %q\n", kubecontext) |
| InsecureRegistries: []string{"mediocre.io"}, | ||
| }, | ||
| }, | ||
| expectedOutput: fmt.Sprintf("No config found for сurrent context %q\n", "context-without-config"), |
Contributor
There was a problem hiding this comment.
The test expectation contains the same typo as in the implementation: "сurrent" uses a Cyrillic 'с'. This should be corrected to use a Latin 'c'.
Suggested change
| expectedOutput: fmt.Sprintf("No config found for сurrent context %q\n", "context-without-config"), | |
| expectedOutput: fmt.Sprintf("No config found for current context %q\n", "context-without-config"), |
| }, | ||
| }, | ||
| }, | ||
| expectedOutput: fmt.Sprintf("No config found for сurrent context %q\n", "context-without-config"), |
Contributor
There was a problem hiding this comment.
This test expectation also contains the typo in "сurrent". Please correct it to use a Latin 'c'.
Suggested change
| expectedOutput: fmt.Sprintf("No config found for сurrent context %q\n", "context-without-config"), | |
| expectedOutput: fmt.Sprintf("No config found for current context %q\n", "context-without-config"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skaffold filter(fix: remove global helm flags from flags sent toskaffold filter#9212)withChange: false(fix: print output from post render hook in console whenwithChange: false#9258)skaffold inspect config-dependencies addto support GCB Repo v2 (feat: extendskaffold inspect config-dependencies addto support GCB Repo v2 #9349)--destinationflag for kaniko build #9415)gcloudcred helper is configured in docker/config.json when using docker go library (feat: default to ADC whengcloudcred helper is configured in docker/config.json when using docker go library #9469)IMAGE_NAMEvar name for the Nth artifact #9517)StandalonePodsSucceededcase when checking status (fix: HandleStandalonePodsSucceededcase when checking status #9580)IMAGE_TAGavailable in buildArgs when used in dockerFROM(fix: makeIMAGE_TAGavailable in buildArgs when used in dockerFROM#9664)failed to port forward(fix: port-forward error logsfailed to port forward#9728)skaffold surveycode (chore: remove theskaffold surveycode #9803)helm version --clientparameter is not supported anymore in v4 (feat(helm): Support Helm v4 for rendering and deployment, drop Helm v2 support for rendering sincehelm version --clientparameter is not supported anymore in v4 #9892)