Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation for Helm Template Value #8991

Merged

Conversation

frankfarzan
Copy link
Contributor

Description
Fixes documentation for helm rendering to make it consistent with rest of the page.

User facing changes (remove if N/A)
Document changes.

@frankfarzan frankfarzan changed the title Fix documentation for Helm Template Value fix documentation for Helm Template Value Aug 4, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 4, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@frankfarzan frankfarzan changed the title fix documentation for Helm Template Value fix: documentation for Helm Template Value Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #8991 (3652626) into main (290280e) will decrease coverage by 6.87%.
Report is 995 commits behind head on main.
The diff coverage is 49.80%.

@@            Coverage Diff             @@
##             main    #8991      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.87%     
==========================================
  Files         515      624     +109     
  Lines       23150    31926    +8776     
==========================================
+ Hits        16317    20312    +3995     
- Misses       5776    10084    +4308     
- Partials     1057     1530     +473     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 416 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 merged commit 58f3d4a into GoogleContainerTools:main Aug 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants