-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new build.local.bazel
entry for local, build-level Bazel configuration
#9230
base: main
Are you sure you want to change the base?
feat: add new build.local.bazel
entry for local, build-level Bazel configuration
#9230
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9230 +/- ##
==========================================
- Coverage 70.48% 63.65% -6.83%
==========================================
Files 515 632 +117
Lines 23150 32559 +9409
==========================================
+ Hits 16317 20727 +4410
- Misses 5776 10238 +4462
- Partials 1057 1594 +537 ☔ View full report in Codecov by Sentry. |
CI error doesn't seem to be related to changes:
|
Gentle ping @ericzzzzzzz @renzodavid9 could you take a look at your earliest convenience? 🙏🏻 |
hi @ar3s3ru sorry for the late review, but I think the existing behavior makes more sense , the bazel config should not be put under build environment stanza, it seems confusing to me why local build has this config, while other cluster, cloudbuild don't. This config is applying buildargs to bazel artifacts, it also seems to suggest that other builder should have corresponding config under local or cloudbuild stanza as well. Another thing is that, we also need to handle conflicts between this args configured through this stanza and those configured in bazel artifacts, should we do a merge or full replacement? Which should have higher priority? This will make things more complex, also ss you can basically achieve the same thing by a little bit repetitions, we probably don't need this change. |
Description
This PR adds a new configuration field in
build.local
specific to Bazel, to specify some build-level parameters for (or to pass to) Bazel.Example usecase: passing
--config=ci
argument.Before:
After: