feat(profile): auto-activated support match exactly#9455
Closed
beastpu wants to merge 4 commits intoGoogleContainerTools:mainfrom
Closed
feat(profile): auto-activated support match exactly#9455beastpu wants to merge 4 commits intoGoogleContainerTools:mainfrom
beastpu wants to merge 4 commits intoGoogleContainerTools:mainfrom
Conversation
Contributor
|
Hi @beastpu thank you for this PR. Would you be able to fix the merge conflicts and failed unit tests? We can review the PR after that. Thanks! |
Contributor
|
Hi @beastpu thank you for your contribution. At this time we will not be able to review your PR for the following reasons:
Regards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
we often use env to automatically trigger the profile, the env represent different business environments and I need to implement precise matching.
For example, there are two environments called cbt and cbtcn, I want to accurately match one of them based on environment variables. However, when the environment variable is set to cbtcn, it matches both environments, which is not what I expect.
Changes
I found that auto-activated by env is fuzzy matched.
so I want to add a new boolean field named exactMatch in the activation struct, which when set to true, would implement an exact match.