Skip to content

Conversation

westoque
Copy link

@westoque westoque commented Oct 16, 2025

Fixes: #9144
See: https://groups.google.com/g/skaffold-users/c/wWbavyfyd5w/m/GE0q6z5aBQAJ

Description
Prevent accidental deployments to wrong cluster by validating that the current kubectl context matches deploy.kubeContext in skaffold.yaml.

Validation is skipped when kubeContext is overridden via CLI or unset.

User facing changes (remove if N/A)
This will show a warning when running "skaffold dev" and not in the right context specified in deploy.kubeContext in skaffold.yaml

genoa@Williams-MacBook-Pro-2:~/GitHub/narralabs/microservices-base(master+*)[hetzner]$ /Users/genoa/.local/share/mise/installs/go/1.25.3/bin/skaffold dev
creating runner: creating deployer: kubectl context mismatch: current context is "hetzner" but deploy.kubeContext is set to "custom" in skaffold.yaml. This prevents accidental deployments to the wrong cluster. To deploy to "custom", switch your context with: kubectl config use-context custom

@westoque westoque requested a review from a team as a code owner October 16, 2025 03:41
@google-cla
Copy link

google-cla bot commented Oct 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @westoque, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Skaffold's deployment safety by implementing a crucial kubectl context validation. It ensures that the active Kubernetes context aligns with the context defined in the skaffold.yaml for deployment, thereby mitigating the risk of deploying applications to the wrong cluster. The feature provides a clear warning to the user upon mismatch, while also allowing for intentional context overrides through command-line arguments.

Highlights

  • Kubectl Context Validation: Introduced a new validation step to ensure the current kubectl context matches the deploy.kubeContext specified in skaffold.yaml.
  • Accidental Deployment Prevention: This validation aims to prevent accidental deployments to unintended Kubernetes clusters by halting execution and providing a clear error message if a mismatch is detected.
  • CLI Override Support: The validation is intelligently skipped if the kubeContext is explicitly overridden via a CLI flag or environment variable, respecting user intent.
  • New Functionality: A new validateKubeContext function has been added to pkg/skaffold/runner/deployer.go and integrated into the GetDeployer function.
  • Comprehensive Testing: Extensive unit tests have been added in pkg/skaffold/runner/deployer_test.go to cover various scenarios, including single and multiple pipeline configurations, and CLI overrides.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@westoque westoque force-pushed the feat/kubectl-context-validation branch from 6e9a1f7 to 1845d33 Compare October 16, 2025 03:42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature to prevent accidental deployments to the wrong Kubernetes cluster by validating the kubectl context. The implementation is clean and the added tests cover the main scenarios. I've identified a minor issue with the user-facing error message that could be confusing, and I've provided a suggestion to clarify it. Additionally, I've recommended an improvement to the tests to make them more robust by checking for the exact error message, which will help prevent similar issues in the future. Overall, this is a solid contribution.

Prevent accidental deployments to wrong cluster by validating that the
current kubectl context matches deploy.kubeContext in skaffold.yaml.

Validation is skipped when kubeContext is overridden via CLI or unset.

Closes: GoogleContainerTools#9144
See: https://groups.google.com/g/skaffold-users/c/wWbavyfyd5w/m/GE0q6z5aBQAJ

Update pkg/skaffold/runner/deployer.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Use suggested test change from gemini
@westoque westoque force-pushed the feat/kubectl-context-validation branch from d3c6d83 to 454f855 Compare October 21, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skaffold doesn't respect kube-context for configuring platform

1 participant