-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: validate kubectl context matches deploy.kubeContext config #9890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: validate kubectl context matches deploy.kubeContext config #9890
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @westoque, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Skaffold's deployment safety by implementing a crucial Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
6e9a1f7
to
1845d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable feature to prevent accidental deployments to the wrong Kubernetes cluster by validating the kubectl context. The implementation is clean and the added tests cover the main scenarios. I've identified a minor issue with the user-facing error message that could be confusing, and I've provided a suggestion to clarify it. Additionally, I've recommended an improvement to the tests to make them more robust by checking for the exact error message, which will help prevent similar issues in the future. Overall, this is a solid contribution.
Prevent accidental deployments to wrong cluster by validating that the current kubectl context matches deploy.kubeContext in skaffold.yaml. Validation is skipped when kubeContext is overridden via CLI or unset. Closes: GoogleContainerTools#9144 See: https://groups.google.com/g/skaffold-users/c/wWbavyfyd5w/m/GE0q6z5aBQAJ Update pkg/skaffold/runner/deployer.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Use suggested test change from gemini
d3c6d83
to
454f855
Compare
Fixes: #9144
See: https://groups.google.com/g/skaffold-users/c/wWbavyfyd5w/m/GE0q6z5aBQAJ
Description
Prevent accidental deployments to wrong cluster by validating that the current kubectl context matches deploy.kubeContext in skaffold.yaml.
Validation is skipped when kubeContext is overridden via CLI or unset.
User facing changes (remove if N/A)
This will show a warning when running "skaffold dev" and not in the right context specified in
deploy.kubeContext
in skaffold.yaml