-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: streamline repo cloning logic in gitutil.go #9891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Suleiman Dibirov <[email protected]>
Summary of ChangesHello @idsulik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Git repository cloning process within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request streamlines the git cloning logic by removing a brittle check on an error message. The new approach correctly falls back to a full clone when a shallow clone by branch fails, which is a good improvement for robustness when dealing with commit SHAs. I've added one comment to further improve the reliability of the fallback logic by ensuring a clean state before retrying the clone operation.
Signed-off-by: Suleiman Dibirov <[email protected]>
Fixes: #9878
Description
Fixed error handling to properly fall back from branch-based cloning to commit SHA fetching when needed.
Previously, the code parsed error messages to determine fallback behavior, which is fragile and can break if git changes its error messages